Skip to content

Conversation

@mhucka
Copy link
Contributor

@mhucka mhucka commented Aug 4, 2025

Update NOTEBOOKS_DEPENDING_ON_UNRELEASED_FEATURES to reflect changes in the contents of the docs/simulate directory. This addresses issue #7556 and follows the procedure described in docs/dev/notebooks.md.

Update `NOTEBOOKS_DEPENDING_ON_UNRELEASED_FEATURES` to reflect changes
in the contents of the `docs/simulate` directory.
@mhucka mhucka marked this pull request as ready for review August 4, 2025 21:55
@mhucka mhucka requested review from a team and vtomole as code owners August 4, 2025 21:55
@github-actions github-actions bot added the Size: XS <10 lines changed label Aug 4, 2025
@mhucka mhucka requested a review from MichaelBroughton August 4, 2025 21:55
@mhucka mhucka marked this pull request as draft August 4, 2025 21:55
@codecov
Copy link

codecov bot commented Aug 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.50%. Comparing base (99320d3) to head (c3075f5).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7557      +/-   ##
==========================================
- Coverage   97.50%   97.50%   -0.01%     
==========================================
  Files        1101     1101              
  Lines       99411    99411              
==========================================
- Hits        96928    96927       -1     
- Misses       2483     2484       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mhucka mhucka marked this pull request as ready for review August 4, 2025 22:18
@mhucka mhucka requested review from dstrain115 and pavoljuhas August 4, 2025 22:18
@dstrain115
Copy link
Collaborator

There don't seem to be any changes in this PR? Did they get merged in another PR?

@mhucka
Copy link
Contributor Author

mhucka commented Aug 6, 2025

There don't seem to be any changes in this PR? Did they get merged in another PR?

This is weird. I see the changed file but this PR doesn't list any changed files. I'm trying to sort it out now …

@mhucka
Copy link
Contributor Author

mhucka commented Aug 6, 2025

I'm going to close this and redo it as a separate PR. My best guess at what happened:

  1. I edited the file and opened the PR
  2. noticed I hadn't merged the latest changes from upstream into my local git copy
  3. pulled and merged the changes from GitHub to my local git copy
  4. did not notice that the merge had changed the file I had edited, overwriting my edits
  5. pushed the changes to the PR branch on GitHub thinking all was fine
  6. GitHub complained about a conflict, which I resolved on GitHub using the GUI

Something unexpected may have happened in #6. Either I accepted the changes in the wrong direction and didn't notice (unlikely, because I remember looking carefully – it's just a 2 line change, after all), or (more likely) another change to the same file in the merge replaced the lines I changed.

@mhucka
Copy link
Contributor Author

mhucka commented Aug 6, 2025

New PR is #7561

@mhucka mhucka closed this Aug 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Size: XS <10 lines changed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants