-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Fix #7556: update isolated_notebook_test.py #7557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Update `NOTEBOOKS_DEPENDING_ON_UNRELEASED_FEATURES` to reflect changes in the contents of the `docs/simulate` directory.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7557 +/- ##
==========================================
- Coverage 97.50% 97.50% -0.01%
==========================================
Files 1101 1101
Lines 99411 99411
==========================================
- Hits 96928 96927 -1
- Misses 2483 2484 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
There don't seem to be any changes in this PR? Did they get merged in another PR? |
This is weird. I see the changed file but this PR doesn't list any changed files. I'm trying to sort it out now … |
|
I'm going to close this and redo it as a separate PR. My best guess at what happened:
Something unexpected may have happened in #6. Either I accepted the changes in the wrong direction and didn't notice (unlikely, because I remember looking carefully – it's just a 2 line change, after all), or (more likely) another change to the same file in the merge replaced the lines I changed. |
|
New PR is #7561 |
Update
NOTEBOOKS_DEPENDING_ON_UNRELEASED_FEATURESto reflect changes in the contents of thedocs/simulatedirectory. This addresses issue #7556 and follows the procedure described indocs/dev/notebooks.md.