-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add note about cirq-ft status on PyPI and suggest alternatives #6868
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
c942b2d
to
e3276ee
Compare
e3276ee
to
59aa477
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6868 +/- ##
==========================================
- Coverage 97.86% 97.85% -0.01%
==========================================
Files 1084 1084
Lines 94013 94013
==========================================
- Hits 92004 91999 -5
- Misses 2009 2014 +5 ☔ View full report in Codecov by Sentry. |
Thank you for trying this. Unfortunately, the issue in question is the description on PyPI, not in GitHub, and so it cannot be addressed with changes to this particular README file. I regret to say that this PR is just not applicable. @ArisAthena would you mind closing this PR? |
@@ -35,6 +35,8 @@ For a comprehensive list all of the interactive Jupyter Notebooks in our repo (i | |||
|
|||
For the latest news regarding Cirq, sign up to the `Cirq-announce email list <https://groups.google.com/forum/#!forum/cirq-announce>`__! | |||
|
|||
**Note:** `cirq-ft` is no longer maintained. Please use `Qualtran` as an alternative for similar functionalities. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Want to add a link? Otherwise, LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dstrain115 I don't think putting this info in the Cirq readme will be all that useful, plus the Cirq README is about to change. I think we should close the PR, since the OP has not responded for 2 weeks.
Closed since this is not the right place to put these changes. |
Changes - Added a note in the README.rst file about
cirq-ft
being no longer maintained. - SuggestedQualtran
as an alternative.Related Issue Addresses #6862