Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note about cirq-ft status on PyPI and suggest alternatives #6868

Closed

Conversation

ArisAthena
Copy link

Changes - Added a note in the README.rst file about cirq-ft being no longer maintained. - Suggested Qualtran as an alternative.

Related Issue Addresses #6862

@ArisAthena ArisAthena requested review from vtomole and a team as code owners December 20, 2024 10:29
@ArisAthena ArisAthena requested a review from viathor December 20, 2024 10:29
Copy link

google-cla bot commented Dec 20, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@CirqBot CirqBot added the Size: XS <10 lines changed label Dec 20, 2024
@ArisAthena ArisAthena force-pushed the update-cirq-ft-pypi-status branch from c942b2d to e3276ee Compare December 20, 2024 10:53
@ArisAthena ArisAthena force-pushed the update-cirq-ft-pypi-status branch from e3276ee to 59aa477 Compare December 20, 2024 10:57
Copy link

codecov bot commented Dec 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.85%. Comparing base (0d9a6ee) to head (59aa477).
Report is 43 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6868      +/-   ##
==========================================
- Coverage   97.86%   97.85%   -0.01%     
==========================================
  Files        1084     1084              
  Lines       94013    94013              
==========================================
- Hits        92004    91999       -5     
- Misses       2009     2014       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mhucka
Copy link
Contributor

mhucka commented Dec 31, 2024

Thank you for trying this. Unfortunately, the issue in question is the description on PyPI, not in GitHub, and so it cannot be addressed with changes to this particular README file.

I regret to say that this PR is just not applicable. @ArisAthena would you mind closing this PR?

@@ -35,6 +35,8 @@ For a comprehensive list all of the interactive Jupyter Notebooks in our repo (i

For the latest news regarding Cirq, sign up to the `Cirq-announce email list <https://groups.google.com/forum/#!forum/cirq-announce>`__!

**Note:** `cirq-ft` is no longer maintained. Please use `Qualtran` as an alternative for similar functionalities.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Want to add a link? Otherwise, LGTM.

Copy link
Contributor

@mhucka mhucka Jan 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dstrain115 I don't think putting this info in the Cirq readme will be all that useful, plus the Cirq README is about to change. I think we should close the PR, since the OP has not responded for 2 weeks.

@dstrain115
Copy link
Collaborator

Closed since this is not the right place to put these changes.

@dstrain115 dstrain115 closed this Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Size: XS <10 lines changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants