Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix XEB error rate computation #6673

Merged
merged 2 commits into from
Jul 22, 2024
Merged

Fix XEB error rate computation #6673

merged 2 commits into from
Jul 22, 2024

Conversation

eliottrosenberg
Copy link
Collaborator

No description provided.

@eliottrosenberg eliottrosenberg requested review from mrwojtek, vtomole, cduck and a team as code owners July 20, 2024 22:03
@CirqBot CirqBot added the Size: XS <10 lines changed label Jul 20, 2024
@CirqBot CirqBot added the size: S 10< lines changed <50 label Jul 21, 2024
@codecov Codecov
Copy link

codecov bot commented Jul 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.82%. Comparing base (ee934fe) to head (4cb607f).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #6673   +/-   ##
=======================================
  Coverage   97.82%   97.82%           
=======================================
  Files        1072     1072           
  Lines       92030    92030           
=======================================
+ Hits        90025    90029    +4     
+ Misses       2005     2001    -4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

NoureldinYosri
NoureldinYosri reviewed Jul 22, 2024
View reviewed changes
Copy link
Collaborator

@NoureldinYosri NoureldinYosri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this mean that the value stored in record.fid is the decay constant in reality not fidility?

@eliottrosenberg
Copy link
Collaborator Author

does this mean that the value stored in record.fid is the decay constant in reality not fidility?

Yes

NoureldinYosri
NoureldinYosri approved these changes Jul 22, 2024
View reviewed changes
Copy link
Collaborator

@NoureldinYosri NoureldinYosri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will approve this now to unblock you but the naming thing is a bigger issue

@NoureldinYosri NoureldinYosri merged commit 45a6bbb into main Jul 22, 2024
37 checks passed
harry-phasecraft pushed a commit to PhaseCraft/Cirq that referenced this pull request Oct 31, 2024
@eliottrosenberg
Fix XEB error rate computation (quantumlib#6673)
fd04f49 
* Fix XEB error rate computation

* Update tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NoureldinYosri NoureldinYosri NoureldinYosri approved these changes

@senecameeks senecameeks Awaiting requested review from senecameeks

@mrwojtek mrwojtek Awaiting requested review from mrwojtek mrwojtek is a code owner

@vtomole vtomole Awaiting requested review from vtomole vtomole is a code owner

@cduck cduck Awaiting requested review from cduck

Assignees
No one assigned
Labels
size: S 10< lines changed <50 Size: XS <10 lines changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eliottrosenberg @NoureldinYosri @CirqBot