Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update files to conform to new mypy standard #6662

Merged
merged 7 commits into from
Jul 10, 2024
Merged

update files to conform to new mypy standard #6662

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
09c4ec3
fix mypy
NoureldinYosri Jul 9, 2024
b1ec57c
Merge branch 'main' into mypy_fix
NoureldinYosri Jul 9, 2024
3f2421d
lint
NoureldinYosri Jul 9, 2024
b4febd1
change method
NoureldinYosri Jul 9, 2024
c50774c
nit
NoureldinYosri Jul 9, 2024
bcf256a
xfail
NoureldinYosri Jul 10, 2024
d6a26e3
typo
NoureldinYosri Jul 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
xfail
  • Loading branch information
@NoureldinYosri
NoureldinYosri committed Jul 10, 2024
commit bcf256a823d508c2d4ab71332fff15b03a0c96c1
2 changes: 2 additions & 0 deletions cirq-core/cirq/ops/common_gates_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -899,6 +899,8 @@ def test_cphase_unitary(angle_rads, expected_unitary):
np.testing.assert_allclose(cirq.unitary(cirq.cphase(angle_rads)), expected_unitary)


# TODO(#6663): fix this use case.
@pytest.mark.xfail
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know why this stopped working? If just the latter assertion is broken can we break it out into it's own test and mark it as failed / track a fix for it, WDYT?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like either comparison between sympy numbers and floats changed or something changed that changes the functions called during comparison ... either way I opened #6663 to fix it.

def test_parameterized_cphase():
assert cirq.cphase(sympy.pi) == cirq.CZ
assert cirq.cphase(sympy.pi / 2) == cirq.CZ**0.5
Expand Down