Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed mpmath version to 1.3.0 due to incompatibility #6477

Merged
merged 5 commits into from
Feb 28, 2024
Merged

fixed mpmath version to 1.3.0 due to incompatibility #6477

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
63a11b2
fixed mpmath version to 1.3.0 due to incompatibility
kenya-sk Feb 26, 2024
583460f
Merge branch 'main' into fix-mpmath-version
pavoljuhas Feb 28, 2024
05c9010
Merge branch 'main' of github.com:kenya-sk/Cirq into fix-mpmath-version
kenya-sk Feb 28, 2024
66eaa05
reduced version restrictions and added policies
kenya-sk Feb 28, 2024
c709243
Merge branch 'fix-mpmath-version' of github.com:kenya-sk/Cirq into fi…
kenya-sk Feb 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fixed mpmath version to 1.3.0 due to incompatibility
  • Loading branch information
@kenya-sk
kenya-sk committed Feb 26, 2024
commit 63a11b2915e5ac9d70f7e9ad2b8642cb0c2082d0
1 change: 1 addition & 0 deletions cirq-core/requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

duet>=0.2.8
matplotlib~=3.0
mpmath~=1.3.0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for tracking this down!

I think we can use a less restrictive mpmath spec to be in sync with sympy requirement for mpmath>=0.19.

Suggested change
mpmath~=1.3.0
# Temporary fix for https://github.com/sympy/sympy/issues/26273
# TODO: remove once `pip install --pre sympy` works in a fresh environment
mpmath<=1.3.*

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pavoljuhas
Thank you for comment!
I have reflected the comment and confirmed that it passes the test.

networkx>=2.4
numpy~=1.16
pandas
Expand Down
Loading