Bump minimum python version to 3.9 #6167

skushnir123 · 2023-06-27T18:29:22Z

Drops support for Python 3.7. and 3.8 For context, see issue: #6159

review-notebook-app · 2023-06-27T18:29:26Z

Check out this pull request on

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

tanujkhattar · 2023-06-27T19:10:44Z

We should drop support for both 3.7 and 3.8 and bump up the minimum version to 3.9. Fixing #6018 would further add support for 3.11

tanujkhattar

Main comment is to also drop support for Python 3.8. You'll also need to update asv.conf.json to Python 3.9.

tanujkhattar · 2023-06-27T20:49:12Z

.github/workflows/ci.yml

@@ -31,7 +31,7 @@ jobs:
      - uses: actions/checkout@v3
      - uses: actions/setup-python@v4
        with:
-          python-version: '3.7'
+          python-version: '3.8'


Update to 3.9, here and elsewhere

Added 3.9 everywhere, as well as dropping some of the conditional checks for 3.7

Maybe we should make a follow-up ticket/issue to thoroughly search the code to ensure the cleanup form 3.7 and 3.8 is complete.

tanujkhattar · 2023-06-27T20:50:19Z

pyproject.toml

@@ -1,6 +1,6 @@
 [tool.black]
 line-length = 100
-target_version = ['py37', 'py38', 'py39']
+target_version = ['py38', 'py39']


Should we also add py310 here?

Should we also add py310 here?

Yes, and py311 as well.

Added both of these, and updated the black formatter because the old version didn't support 311

pavoljuhas · 2023-06-27T21:00:06Z

Please also check all instances of sys.version and sys.version_info in the code and adjust as needed.
For example, it should be possible to remove the use_async_mock decorator because it only applies to 3.7

Cirq/cirq-google/cirq_google/engine/test_utils.py

Lines 22 to 24 in 6565fc5

    
           uses_async_mock = pytest.mark.xfail( 
        
               sys.version_info < (3, 8, 0), reason='unittest.mock.AsyncMock is only available in python 3.8+' 
        
           )

Another thing to check are all python_version specifiers in the requirement *.txt files.
For example, the dependency below can be removed if we require Python >= 3.9.

Cirq/cirq-core/requirements.txt

Lines 3 to 4 in 6565fc5

    
           # functools.cached_property was introduced in python 3.8 
        
           backports.cached_property~=1.0.1; python_version < '3.8'

skushnir123 · 2023-06-28T15:31:52Z

Main comment is to also drop support for Python 3.8. You'll also need to update asv.conf.json to Python 3.9.

Yup, made these changes

pavoljuhas

Almost there, however there are few more things relevant only for abandoned Pythons. Please consider updating your PR with

git pull https://github.com/pavoljuhas/Cirq.git pr6167-amend-1

skushnir123/Cirq@drop-37...pavoljuhas:pr6167-amend-1

There are also Dockerfile-s that use old python and will need update, but that is perhaps better left for another PR - unless they block the tests here, #6175.

skushnir123 · 2023-06-29T02:43:27Z

git pull https://github.com/pavoljuhas/Cirq.git pr6167-amend-1

Thanks for adding on those changes! I just added those to my PR. Let me know if there is anything else to remove/change.

skushnir123 · 2023-06-29T14:38:30Z

Almost there, however there are few more things relevant only for abandoned Pythons. Please consider updating your PR with
git pull https://github.com/pavoljuhas/Cirq.git pr6167-amend-1
skushnir123/Cirq@drop-37...pavoljuhas:pr6167-amend-1

There are also Dockerfile-s that use old python and will need update, but that is perhaps better left for another PR - unless they block the tests here, #6175.

I don't think the Dockerfile's are failing any tests here.

pavoljuhas

Thanks for taking care of this!

tanujkhattar

Thanks Samuel and Pavol! I've removed Python 3.7 and 3.8 from required CI checks and the PR is ready to be merged now!

* dropped 3.7 support * Update setup.py * Removed 3.8 as well * changing some more 3.8's to 3.9's * reformat * Update pyproject.toml * Update setup.py * changing notebook python versions * Update setup.py * testing * Update packaging_test.sh * Update packaging_test.sh * Update packaging_test.sh * adding 311 * updating formatter * Bump Python version for CI actions to 3.9 * Remove code specific to Python <= 3.8 only * Drop redundant python_version checks from requirement files * Fix required Python version in the installation doc * Clean redundant assertion * Skip coverage for code run in subprocess * Suggest a more recent cirq for old pythons --------- Co-authored-by: Pavol Juhas <juhas@google.com>

dropped 3.7 support

13d1aad

skushnir123 added 2 commits June 27, 2023 14:45

Update setup.py

09df863

Merge branch 'master' into drop-37

3f2c731

CirqBot added the size: M 50< lines changed <250 label Jun 27, 2023

skushnir123 marked this pull request as ready for review June 27, 2023 20:36

skushnir123 requested review from a team, vtomole, cduck, HGSilveri, ma5x, pschindler, dabacon, ColemanCollins, nakardo, gmauricio, wcourtney and verult as code owners June 27, 2023 20:36

Merge branch 'master' into drop-37

e6e07d1

tanujkhattar requested changes Jun 27, 2023

View reviewed changes

skushnir123 added 8 commits June 27, 2023 23:41

Merge branch 'master' into drop-37

7cd30b5

Removed 3.8 as well

078ea82

changing some more 3.8's to 3.9's

5b7f497

reformat

bc0a9fe

Update pyproject.toml

351e48f

Update setup.py

d6d0ff8

changing notebook python versions

8816a5d

Update setup.py

40b9631

skushnir123 added 5 commits June 28, 2023 11:07

Update packaging_test.sh

c941c3c

Update packaging_test.sh

57ae7c7

Update packaging_test.sh

fc2ab78

adding 311

142197a

updating formatter

67e0159

skushnir123 closed this Jun 28, 2023

skushnir123 reopened this Jun 28, 2023

tanujkhattar assigned pavoljuhas Jun 28, 2023

Merge branch 'master' into drop-37

0fb46e0

maffoo changed the title ~~dropped 3.7 support~~ Bump minimum python version to 3.9 Jun 29, 2023

pavoljuhas added 5 commits June 28, 2023 17:39

Bump Python version for CI actions to 3.9

ed1a979

Remove code specific to Python <= 3.8 only

f902d80

Drop redundant python_version checks from requirement files

362d884

Fix required Python version in the installation doc

084903e

Clean redundant assertion

c3eaedb

pavoljuhas mentioned this pull request Jun 29, 2023

Update Python version in Dockerfile-s #6175

Closed

Skip coverage for code run in subprocess

68f9113

pavoljuhas requested changes Jun 29, 2023

View reviewed changes

Suggest a more recent cirq for old pythons

ba8c533

pavoljuhas approved these changes Jun 29, 2023

View reviewed changes

tanujkhattar approved these changes Jun 29, 2023

View reviewed changes

tanujkhattar merged commit bc09047 into quantumlib:master Jun 29, 2023

pavoljuhas mentioned this pull request Jun 29, 2023

Drop support for Python 3.7 and 3.8? #6159

Closed

jackreeceejini mentioned this pull request Jul 8, 2023

Update dockerfiles #6188

Merged

maffoo mentioned this pull request Jul 26, 2023

Drop support for python < 3.9 google/duet#81

Merged

pavoljuhas mentioned this pull request Jan 6, 2024

Replace _compat.cached_property with functools.cached_property #6395

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bump minimum python version to 3.9 #6167

Bump minimum python version to 3.9 #6167

skushnir123 commented Jun 27, 2023 •

edited

Loading

review-notebook-app bot commented Jun 27, 2023

tanujkhattar commented Jun 27, 2023

tanujkhattar left a comment

tanujkhattar Jun 27, 2023

skushnir123 Jun 28, 2023

skushnir123 Jun 28, 2023

tanujkhattar Jun 27, 2023

pavoljuhas Jun 27, 2023

skushnir123 Jun 28, 2023

pavoljuhas commented Jun 27, 2023

skushnir123 commented Jun 28, 2023

pavoljuhas left a comment

skushnir123 commented Jun 29, 2023

skushnir123 commented Jun 29, 2023

pavoljuhas left a comment

tanujkhattar left a comment

Bump minimum python version to 3.9 #6167

Bump minimum python version to 3.9 #6167

Conversation

skushnir123 commented Jun 27, 2023 • edited Loading

review-notebook-app bot commented Jun 27, 2023

tanujkhattar commented Jun 27, 2023

tanujkhattar left a comment

Choose a reason for hiding this comment

tanujkhattar Jun 27, 2023

Choose a reason for hiding this comment

skushnir123 Jun 28, 2023

Choose a reason for hiding this comment

skushnir123 Jun 28, 2023

Choose a reason for hiding this comment

tanujkhattar Jun 27, 2023

Choose a reason for hiding this comment

pavoljuhas Jun 27, 2023

Choose a reason for hiding this comment

skushnir123 Jun 28, 2023

Choose a reason for hiding this comment

pavoljuhas commented Jun 27, 2023

skushnir123 commented Jun 28, 2023

pavoljuhas left a comment

Choose a reason for hiding this comment

skushnir123 commented Jun 29, 2023

skushnir123 commented Jun 29, 2023

pavoljuhas left a comment

Choose a reason for hiding this comment

tanujkhattar left a comment

Choose a reason for hiding this comment

skushnir123 commented Jun 27, 2023 •

edited

Loading