Inconsistent ordering of tags #6123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
tanujkhattar
requested changes
Jun 6, 2023
There was a problem hiding this comment.
Thanks for opening your first PR! The preferred solution here would be to follow Matthew's comment - #5949 (comment)
Co-authored-by: Tanuj Khattar <tanujkhattar@google.com>
…3/cirq into inconsistent-ordering-of-tags
harry-phasecraft
pushed a commit
to PhaseCraft/Cirq
that referenced
this pull request
Oct 31, 2024
* added sorted(*) to fix issue of identical sets being labeled unequal and added tests * only comparing description when given * Update cirq-core/cirq/ops/gateset_test.py Co-authored-by: Tanuj Khattar <tanujkhattar@google.com> * ran formatter --------- Co-authored-by: Tanuj Khattar <tanujkhattar@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minimal change to fix #5949.