Add Parameter to cirq_google #6102
Conversation
dstrain115
commented
May 22, 2023
dstrain115
commented
- This object will be able to store device parameters and is intended to be attached as a sweep meta-data.
- This object will be able to store device parameters and is intended to be attached as a sweep meta-data.
dstrain115
requested review from
wcourtney,
a team,
vtomole,
cduck and
verult
as code owners
| class Parameter(SupportsParameter): | ||
| """Class for specifying device parameters. | ||
|
|
||
| For instance, verying the length of pulses, timing, etc. |
|
|
||
|
|
||
| @dataclasses.dataclass | ||
| class Parameter(SupportsParameter): |
There was a problem hiding this comment.
To prevent future parameter types from colliding, could for this name to be more specific? Maybe DeviceParameter?
There was a problem hiding this comment.
Changed. Originally chose Parameter to keep compatibility with internal naming, but we should probably convert the internal name too.
|
Design doc is here (internal only): https://docs.google.com/document/d/1-yVZ4w0NNURW4SZV3yxsl_rNuVGYW6AqmxMeIE-vZlo The background and objective is still accurate. However, it is obsolete as we changed the plan to use sweep metadata instead. That RFC is here: |
| import cirq | ||
|
|
||
|
|
||
| class SupportsParameter(Protocol): |
There was a problem hiding this comment.
Should this be SupportsDeviceParameter?
* Add Parameter to cirq_google - This object will be able to store device parameters and is intended to be attached as a sweep meta-data. - Add study __init__ as a cirq_google module. Co-authored-by: Victory Omole <vtomole2@gmail.com>
