Fix typing in numpy function arguments #5657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
pavoljuhas
commented
Jun 30, 2022
pavoljuhas
commented
- Assure mypy that np.isclose receives a concrete scalar argument
- Turn off type check for TParamValComplex used in numpy expressions
Avoid incompatible type error on a possibility of numbers.Complex type.
Assume it is not sympy.Expr and hope for the best.
dabacon
previously requested changes
Jun 30, 2022
Also use assertions to tell mypy that PauliString.coefficient is complex when not parameterized.
Assume GlobalPhaseGate.coefficient is a numerical value otherwise.
pavoljuhas
force-pushed
the
fix-mypy-numpy-errors-2
branch
from
ada2527 to
8f6233f
Compare
MichaelBroughton
approved these changes
Jul 6, 2022
MichaelBroughton
added
the
automerge
CirqBot
added
the
front_of_queue_automerge
|
Automerge cancelled: A status check is failing. |
CirqBot
removed
automerge
MichaelBroughton
added
the
automerge
|
Automerge cancelled: A status check is failing. |
CirqBot
removed
the
automerge
pavoljuhas
added
the
automerge
CirqBot
added
the
front_of_queue_automerge
CirqBot
removed
automerge
rht
pushed a commit
to rht/Cirq
that referenced
this pull request
May 1, 2023
- Assure mypy that np.isclose receives a concrete scalar argument - Turn off type check for TParamValComplex used in numpy expressions
harry-phasecraft
pushed a commit
to PhaseCraft/Cirq
that referenced
this pull request
Oct 31, 2024
- Assure mypy that np.isclose receives a concrete scalar argument - Turn off type check for TParamValComplex used in numpy expressions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.