Replace SwapPermutationReplacer with cirq.map_operations
#5655
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtomole
reviewed
Jul 6, 2022
| @@ -307,7 +297,7 @@ def compile_circuit( | |||
| # as well, we allow this to be passed in. This compiler is not allowed to | |||
| # change the order of the qubits. | |||
| return CompilationResult( | |||
| circuit=compiler(swap_networks[0].circuit), mapping=mapping, parity_map=parity_map | |||
There was a problem hiding this comment.
Why was swap_networks[0].circuit being passed in in the first place instead of routed_circuit?
There was a problem hiding this comment.
Because the original optimizer mutated the circuit. routed_circuit was a variable storing a reference to swap_networks[0].circuit and since the underlying circuit was being mutated; it didn't matter whether you pass swap_networks[0].circuit or routed_circuit.
Now, routed_circuit stores a modified copy of swap_networks[0].circuit and therefore we need to pass routed_circuit instead of swap_networks[0].circuit.
rht
pushed a commit
to rht/Cirq
that referenced
this pull request
May 1, 2023
harry-phasecraft
pushed a commit
to PhaseCraft/Cirq
that referenced
this pull request
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #5028
Since
SwapPermutationReplaceris not exposed outside the file, we don't need to go through the deprecation cycle