Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove decompose_operation deprecation from device. #5380

Merged
merged 6 commits into from
May 21, 2022
Merged

Remove decompose_operation deprecation from device. #5380

merged 6 commits into from
May 21, 2022

Conversation

MichaelBroughton
Copy link
Collaborator

More device v0.15 deprecation removals.

@CirqBot CirqBot added the size: M 50< lines changed <250 label May 19, 2022
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

dstrain115
dstrain115 approved these changes May 20, 2022
View reviewed changes
Copy link
Collaborator

@dstrain115 dstrain115 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like some unused imports in the pylint, otherwise, LGTM

@MichaelBroughton MichaelBroughton added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label May 20, 2022
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label May 20, 2022
@CirqBot
Copy link
Collaborator

CirqBot commented May 20, 2022

Automerge cancelled: A status check is failing.

@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels May 20, 2022
vtomole
vtomole approved these changes May 21, 2022
View reviewed changes
Copy link
Collaborator

@vtomole vtomole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vtomole vtomole added automerge Tells CirqBot to sync and merge this PR. (If it's running.) and removed size: M 50< lines changed <250 labels May 21, 2022
@CirqBot CirqBot added front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. size: M 50< lines changed <250 labels May 21, 2022
@CirqBot CirqBot merged commit ca48790 into quantumlib:master May 21, 2022
@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels May 21, 2022
rht pushed a commit to rht/Cirq that referenced this pull request May 1, 2023
@MichaelBroughton @rht
Remove decompose_operation deprecation from device. (quantumlib#5380)
d41757a 
More device v0.15 deprecation removals.
harry-phasecraft pushed a commit to PhaseCraft/Cirq that referenced this pull request Oct 31, 2024
@MichaelBroughton
Remove decompose_operation deprecation from device. (quantumlib#5380)
6134c8d 
More device v0.15 deprecation removals.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dstrain115 dstrain115 dstrain115 approved these changes

@vtomole vtomole vtomole approved these changes

@cduck cduck Awaiting requested review from cduck

@HGSilveri HGSilveri Awaiting requested review from HGSilveri

@dabacon dabacon Awaiting requested review from dabacon

@ColemanCollins ColemanCollins Awaiting requested review from ColemanCollins

@nakardo nakardo Awaiting requested review from nakardo

@gmauricio gmauricio Awaiting requested review from gmauricio

@wcourtney wcourtney Awaiting requested review from wcourtney

@verult verult Awaiting requested review from verult

Assignees
No one assigned
Labels
size: M 50< lines changed <250
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MichaelBroughton @CirqBot @vtomole @dstrain115