Extract cirq-pasqal #4241
Merged
Extract cirq-pasqal #4241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on assertion logic in json serialization tests
balopat
requested review from
cduck,
HGSilveri,
vtomole and
a team
as code owners
…/Cirq into fix_deprecation_logic_json_tests
balopat
requested review from
dabacon,
gmauricio,
nakardo and
wcourtney
as code owners
dstrain115
approved these changes
Jun 29, 2021
| @@ -1,4 +1,4 @@ | |||
| # Copyright 2020 The Cirq Developers | |||
| # Copyright 2021 The Cirq Developers | |||
There was a problem hiding this comment.
nit: I am not sure if it matters, but this init file renaming is weird. It is taking the top-level init to the json_test_data init which makes the diff look funny and screws up git blame. I am not sure it matters too much though, if we can't figure out how to fix it.
balopat
added
the
automerge
CirqBot
added
the
front_of_queue_automerge
|
Automerge cancelled: A required status check is not present. Missing statuses: ['Build docs', 'Build protos', 'Changed files test', 'Coverage check', 'Doc test', 'Format check', 'Lint check', 'Misc check', 'Notebook formatting', 'Pytest MacOS (3.7)', 'Pytest MacOS (3.8)', 'Pytest Ubuntu (3.7)', 'Pytest Ubuntu (3.8)', 'Pytest Windows (3.7)', 'Pytest Windows (3.8)', 'Type check'] |
CirqBot
removed
automerge
balopat
added
the
automerge
CirqBot
added
the
front_of_queue_automerge
CirqBot
removed
automerge
rht
pushed a commit
to rht/Cirq
that referenced
this pull request
May 1, 2023
Extracts cirq-pasqal as a separate module. Merge after quantumlib#4239, a fix for json testing and deprecation warning deduping and quantumlib#4250, a fix for flnyt / minimal pytest dependencies (it contains them currently)
harry-phasecraft
pushed a commit
to PhaseCraft/Cirq
that referenced
this pull request
Oct 31, 2024
Extracts cirq-pasqal as a separate module. Merge after quantumlib#4239, a fix for json testing and deprecation warning deduping and quantumlib#4250, a fix for flnyt / minimal pytest dependencies (it contains them currently)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracts cirq-pasqal as a separate module.
Merge after #4239, a fix for json testing and deprecation warning deduping and #4250, a fix for flnyt / minimal pytest dependencies (it contains them currently)