Skip to content

Support adding numpy arrays to GridQubits #3131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 10, 2020
Merged

Support adding numpy arrays to GridQubits #3131

merged 3 commits into from
Jul 10, 2020

Conversation

dabacon
Copy link
Collaborator

@dabacon dabacon commented Jul 10, 2020

Fixes #3130

@dabacon dabacon requested a review from viathor July 10, 2020 04:42
@googlebot googlebot added the cla: yes Makes googlebot stop complaining. label Jul 10, 2020
viathor
viathor approved these changes Jul 10, 2020
View reviewed changes
Copy link
Collaborator

@viathor viathor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM & thanks!

@dabacon dabacon merged commit c869e0e into quantumlib:master Jul 10, 2020
tonybruguier pushed a commit to tonybruguier/Cirq that referenced this pull request Aug 23, 2020
@dabacon
Support adding numpy arrays to GridQubits (quantumlib#3131)
b3a16da
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viathor viathor viathor approved these changes

Assignees
No one assigned
Labels
cla: yes Makes googlebot stop complaining.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support numpy integer arrays as grid offsets
3 participants
@dabacon @viathor @googlebot