Skip to content

Fix flakes in random_circuit_test #3084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jun 11, 2020
Merged

Fix flakes in random_circuit_test #3084

merged 7 commits into from
Jun 11, 2020

Conversation

dabacon
Copy link
Collaborator

@dabacon dabacon commented Jun 9, 2020 •
edited
Loading

Sometimes test data (about 1 in 100) had no gates that act on few enough qubits to fit with number of qubits.

  • Cleans up the generating function which was a bit of a mess to read. For tests prefer explicitness over conciseness.
  • Fixes missing f in error and improves test case for that error.

@googlebot googlebot added the cla: yes Makes googlebot stop complaining. label Jun 9, 2020
@dabacon dabacon requested a review from dstrain115 June 9, 2020 23:09
@dabacon
Copy link
Collaborator Author

dabacon commented Jun 9, 2020

Fixes #3083

@dabacon dabacon merged commit d3ce7cc into master Jun 11, 2020
MichaelBroughton added a commit that referenced this pull request Jun 12, 2020
@MichaelBroughton @mpharrigan
@AnimeshSinha1309 @maffoo @dabacon
Added api docs gen (copy from TFQ). (#3089)
f3c556d 
* [SVG] Noise hack and font fix (#3076)


 - Specify the font. This should not be a change for viewing in Jupyter notebook but fixes opening the svg data in e.g. inkscape where the default font is different and the boxes aren't the right size
 - Don't display virtual tags (for noise) xref #2905

* Support multi-qubit measurement in plot_state_histogram (#3054)

* Add generated code for batch.proto (#3086)

Review: @dstrain115

* Fix flakes in random_circuit_test (#3084)

* Added api docs gen (copy from TFQ).

* updated site_path prefix.

* removed pre-built.

* rename.

* move to dev_tools.

* removed __future__ and formatting.

* yet more formatting.

Co-authored-by: Matthew Harrigan <mpharrigan@google.com>
Co-authored-by: Animesh Sinha <AnimeshSinha1309@gmail.com>
Co-authored-by: Matthew Neeley <maffoo@google.com>
Co-authored-by: Dave Bacon <dabacon@gmail.com>
MichaelBroughton added a commit that referenced this pull request Jun 12, 2020
@lamberta @mpharrigan
@AnimeshSinha1309 @maffoo @dabacon @matpompili @MichaelBroughton
Docs site setup (#3085)
77821e3 
* [SVG] Noise hack and font fix (#3076)


 - Specify the font. This should not be a change for viewing in Jupyter notebook but fixes opening the svg data in e.g. inkscape where the default font is different and the boxes aren't the right size
 - Don't display virtual tags (for noise) xref #2905

* Support multi-qubit measurement in plot_state_histogram (#3054)

* Add generated code for batch.proto (#3086)

Review: @dstrain115

* Fix flakes in random_circuit_test (#3084)

* Fix Quirk import extra gates bug

* Move image files to docs/images/

* Move unneeded site assets

* Move Sphinx templates, Makefile, conf, and init

* Added api docs gen (copy from TFQ). (#3089)

* [SVG] Noise hack and font fix (#3076)


 - Specify the font. This should not be a change for viewing in Jupyter notebook but fixes opening the svg data in e.g. inkscape where the default font is different and the boxes aren't the right size
 - Don't display virtual tags (for noise) xref #2905

* Support multi-qubit measurement in plot_state_histogram (#3054)

* Add generated code for batch.proto (#3086)

Review: @dstrain115

* Fix flakes in random_circuit_test (#3084)

* Added api docs gen (copy from TFQ).

* updated site_path prefix.

* removed pre-built.

* rename.

* move to dev_tools.

* removed __future__ and formatting.

* yet more formatting.

Co-authored-by: Matthew Harrigan <mpharrigan@google.com>
Co-authored-by: Animesh Sinha <AnimeshSinha1309@gmail.com>
Co-authored-by: Matthew Neeley <maffoo@google.com>
Co-authored-by: Dave Bacon <dabacon@gmail.com>

* Move doc tools to /dev_tools/docs/

* Move examples index into tutorials/

* Move basics tutorial into tutorials/

* Encode URL bracket so not mistaken for template.

* Update references to moves docs and image files.

* Update references to docs_coverage_test.py

* Format py with check/format-incremental --apply

* Move Sphinx RST files

* Add _index.yaml for site

* Add initial _book.yaml for leftnav

* Manually format docs/_sphinx/conf.py for CI

* Update references to moved api.rst file

* Move docs/_sphinx to dev_tools/docs/sphinx

* Update README.rst path for snippets_test.py

* Move run_doctest to dev_tools/docs/

* Move build-docs.sh to dev_tools/docs/sphinx/

* Update references to build-docs.sh

* Remove build_docs CI test

Co-authored-by: Matthew Harrigan <mpharrigan@google.com>
Co-authored-by: Animesh Sinha <AnimeshSinha1309@gmail.com>
Co-authored-by: Matthew Neeley <maffoo@google.com>
Co-authored-by: Dave Bacon <dabacon@gmail.com>
Co-authored-by: Matteo Pompili <matpompili@gmail.com>
Co-authored-by: MichaelBroughton <MichaelBroughton@users.noreply.github.com>
balopat pushed a commit to balopat/Cirq that referenced this pull request Aug 18, 2020
@MichaelBroughton @mpharrigan
@AnimeshSinha1309 @maffoo @dabacon @balopat
Added api docs gen (copy from TFQ). (quantumlib#3089)
39cbd1c 
* [SVG] Noise hack and font fix (quantumlib#3076)

 - Specify the font. This should not be a change for viewing in Jupyter notebook but fixes opening the svg data in e.g. inkscape where the default font is different and the boxes aren't the right size
 - Don't display virtual tags (for noise) xref quantumlib#2905

* Support multi-qubit measurement in plot_state_histogram (quantumlib#3054)

* Add generated code for batch.proto (quantumlib#3086)

Review: @dstrain115

* Fix flakes in random_circuit_test (quantumlib#3084)

* Added api docs gen (copy from TFQ).

* updated site_path prefix.

* removed pre-built.

* rename.

* move to dev_tools.

* removed __future__ and formatting.

* yet more formatting.

Co-authored-by: Matthew Harrigan <mpharrigan@google.com>
Co-authored-by: Animesh Sinha <AnimeshSinha1309@gmail.com>
Co-authored-by: Matthew Neeley <maffoo@google.com>
Co-authored-by: Dave Bacon <dabacon@gmail.com>
balopat pushed a commit to balopat/Cirq that referenced this pull request Aug 18, 2020
@lamberta @mpharrigan
@AnimeshSinha1309 @maffoo @dabacon @matpompili @MichaelBroughton @balopat
Docs site setup (quantumlib#3085)
fbc35e2 
* [SVG] Noise hack and font fix (quantumlib#3076)

 - Specify the font. This should not be a change for viewing in Jupyter notebook but fixes opening the svg data in e.g. inkscape where the default font is different and the boxes aren't the right size
 - Don't display virtual tags (for noise) xref quantumlib#2905

* Support multi-qubit measurement in plot_state_histogram (quantumlib#3054)

* Add generated code for batch.proto (quantumlib#3086)

Review: @dstrain115

* Fix flakes in random_circuit_test (quantumlib#3084)

* Fix Quirk import extra gates bug

* Move image files to docs/images/

* Move unneeded site assets

* Move Sphinx templates, Makefile, conf, and init

* Added api docs gen (copy from TFQ). (quantumlib#3089)

* [SVG] Noise hack and font fix (quantumlib#3076)

 - Specify the font. This should not be a change for viewing in Jupyter notebook but fixes opening the svg data in e.g. inkscape where the default font is different and the boxes aren't the right size
 - Don't display virtual tags (for noise) xref quantumlib#2905

* Support multi-qubit measurement in plot_state_histogram (quantumlib#3054)

* Add generated code for batch.proto (quantumlib#3086)

Review: @dstrain115

* Fix flakes in random_circuit_test (quantumlib#3084)

* Added api docs gen (copy from TFQ).

* updated site_path prefix.

* removed pre-built.

* rename.

* move to dev_tools.

* removed __future__ and formatting.

* yet more formatting.

Co-authored-by: Matthew Harrigan <mpharrigan@google.com>
Co-authored-by: Animesh Sinha <AnimeshSinha1309@gmail.com>
Co-authored-by: Matthew Neeley <maffoo@google.com>
Co-authored-by: Dave Bacon <dabacon@gmail.com>

* Move doc tools to /dev_tools/docs/

* Move examples index into tutorials/

* Move basics tutorial into tutorials/

* Encode URL bracket so not mistaken for template.

* Update references to moves docs and image files.

* Update references to docs_coverage_test.py

* Format py with check/format-incremental --apply

* Move Sphinx RST files

* Add _index.yaml for site

* Add initial _book.yaml for leftnav

* Manually format docs/_sphinx/conf.py for CI

* Update references to moved api.rst file

* Move docs/_sphinx to dev_tools/docs/sphinx

* Update README.rst path for snippets_test.py

* Move run_doctest to dev_tools/docs/

* Move build-docs.sh to dev_tools/docs/sphinx/

* Update references to build-docs.sh

* Remove build_docs CI test

Co-authored-by: Matthew Harrigan <mpharrigan@google.com>
Co-authored-by: Animesh Sinha <AnimeshSinha1309@gmail.com>
Co-authored-by: Matthew Neeley <maffoo@google.com>
Co-authored-by: Dave Bacon <dabacon@gmail.com>
Co-authored-by: Matteo Pompili <matpompili@gmail.com>
Co-authored-by: MichaelBroughton <MichaelBroughton@users.noreply.github.com>
tonybruguier pushed a commit to tonybruguier/Cirq that referenced this pull request Aug 23, 2020
@dabacon
Fix flakes in random_circuit_test (quantumlib#3084)
1774c3d
@mpharrigan mpharrigan deleted the fixrandom branch January 16, 2021 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dstrain115 dstrain115 dstrain115 approved these changes

Assignees
No one assigned
Labels
cla: yes Makes googlebot stop complaining.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dabacon @dstrain115 @googlebot