-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Closed
Labels
area/docsarea/notebook-testinggood first issueThis issue can be resolved by someone who is not familiar with the codebase. A good starting issue.This issue can be resolved by someone who is not familiar with the codebase. A good starting issue.kind/bug-reportSomething doesn't seem to work.Something doesn't seem to work.kind/healthFor CI/testing/release process/refactoring/technical debt itemsFor CI/testing/release process/refactoring/technical debt itemspriority/p2Next release should contain itNext release should contain ittriage/acceptedA consensus emerged that this bug report, feature request, or other action should be worked onA consensus emerged that this bug report, feature request, or other action should be worked on
Description
Description of the issue
get_qcs_objects_for_notebook
was added in #4286 and is super useful to abstract out the authentication logic for accessing QCS. However, I think there are a few rough edges -- from a user perspective, I haven't dug into the technical details yet.
- In the getting started with QCS tutorial, the object is used for authentication and verification that the authentication went through (
device_sampler.is_signed_in
) but after that, there's no usage of thedevice_sampler
object. This doesn't look like the intended usage of an object specifically has adevice
andsampler
objects ? - It looks like
sqrt_iswap
gateset string is hardcoded deep inside theget_qcs_objects_for_notebook
method. This also looks like a bug and something that shouldn't be intended?sampler = get_engine_sampler(processor_id, gate_set_name="sqrt_iswap")
Cirq version
0.13.0
Metadata
Metadata
Labels
area/docsarea/notebook-testinggood first issueThis issue can be resolved by someone who is not familiar with the codebase. A good starting issue.This issue can be resolved by someone who is not familiar with the codebase. A good starting issue.kind/bug-reportSomething doesn't seem to work.Something doesn't seem to work.kind/healthFor CI/testing/release process/refactoring/technical debt itemsFor CI/testing/release process/refactoring/technical debt itemspriority/p2Next release should contain itNext release should contain ittriage/acceptedA consensus emerged that this bug report, feature request, or other action should be worked onA consensus emerged that this bug report, feature request, or other action should be worked on
Type
Projects
Status
Done