Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Too many implementations of state tomography #2737

Open
viathor opened this issue Feb 5, 2020 · 5 comments
Open

Too many implementations of state tomography #2737

viathor opened this issue Feb 5, 2020 · 5 comments
Labels
area/experiments area/tomography complexity/medium introduces/modifies 3-5 concepts, takes max up to a month for an advanced contributor kind/health For CI/testing/release process/refactoring/technical debt items skill-level/advanced One or more of the areas need a solid understanding. triage/accepted A consensus emerged that this bug report, feature request, or other action should be worked on
Milestone
2025-T6: Code hea...

Comments

@viathor
Copy link
Collaborator

viathor commented Feb 5, 2020

We have three implementations of state tomography:

  • for 1-qubit states,
  • for 2-qubit states,
  • for n-qubit states for arbitrary n.

The last one isn't well tested (yet). Once it is, we should compare performance and if there isn't a clear advantage to the fixed-size implementations we should remove them.
This was referenced Feb 5, 2020
Closed
Merged
@mpharrigan
Copy link
Collaborator

Should we keep this open? The linked issue fixes the bug in n-qubit tomography but the larger issue is still present

@mpharrigan mpharrigan reopened this Feb 7, 2020
@viathor
Copy link
Collaborator Author

viathor commented Feb 7, 2020

Yes, thank you. My comment on PR #2739 incorrectly said that it fixed #2737. It should have said that it fixed #2738.

@dabacon
Copy link
Collaborator

dabacon commented May 8, 2020

There can never be too many implementations of state tomography :)

But yes we should unify these standard method of state tomography (there are many others).

@balopat balopat added area/tomography skill-level/advanced One or more of the areas need a solid understanding. triage/accepted A consensus emerged that this bug report, feature request, or other action should be worked on area/experiments complexity/medium introduces/modifies 3-5 concepts, takes max up to a month for an advanced contributor labels Sep 1, 2020
@maffoo maffoo added the kind/health For CI/testing/release process/refactoring/technical debt items label Sep 22, 2020
@MichaelBroughton
Copy link
Collaborator

Is this still an open concern ?

@maffoo
Copy link
Contributor

maffoo commented Mar 28, 2022

I'd say yes this is still a concern. It'd be nice to unify these tomography functions, but not a blocker for 1.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/experiments area/tomography complexity/medium introduces/modifies 3-5 concepts, takes max up to a month for an advanced contributor kind/health For CI/testing/release process/refactoring/technical debt items skill-level/advanced One or more of the areas need a solid understanding. triage/accepted A consensus emerged that this bug report, feature request, or other action should be worked on
Projects
Cirq 2025 roadmap
Status: No status
Milestone
2025-T6: Code health and project main...
Development

No branches or pull requests
7 participants
@dabacon @maffoo @balopat @mhucka @MichaelBroughton @mpharrigan @viathor