Fix telemetry not support v1.0 #483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your PR @wingyplus ❤️ Can you correct the requirement so that for example |
Pull Request Test Coverage Report for Build 201b3ca71b0ee6665dd8f1fe57bf9a65c38bef66-PR-483
💛 - Coveralls |
The patch try to make this library support telemetry v1.0. Currently, it doesn't because it contraint between [0.4.3, 1.0.0). Fix by using `or` constraint to support both version.
wingyplus
force-pushed
the
fix-telemetry-1-0
branch
from
eb9dc82
to
201b3ca
Compare
|
@maennchen Oh, that's my mistake. We should constraint to |
maennchen
approved these changes
Jul 21, 2021
|
@maennchen Can we merge this one? |
|
@wingyplus Oops, sorry for the delay. |
|
@wingyplus Released as |
|
@maennchen Thank you. 🙇♂️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The patch try to make this library support telemetry v1.0. Currently, it
doesn't because it contraint between [0.4.3, 1.0.0). Fix by using
orconstraint to support both version.