Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement date library using elixir 1.8s core functionality #405

Merged
merged 1 commit into from
Jun 18, 2019

Conversation

LostKobrakai
Copy link
Contributor

As the title says. I'm just not sure what would be the best way to put tzdata into the deps, as really it's probably not even an optional dependency. It would just need to be available for :dev and :test.

@maennchen
Copy link
Member

@LostKobrakai Thanks a lot for your PR. If you don't mind I would keep this PR open until tzdata is stable and then immediately merge & create a new release.

Why would it only need to be available for dev and test? This should work just as well in prod.

@maennchen maennchen self-assigned this Mar 28, 2019
@LostKobrakai
Copy link
Contributor Author

LostKobrakai commented Mar 28, 2019

By now tzdata is the only actual implementation for an elixir timezone database, but the code I added would work with any implementation, so there's no need for quantum to require any tzdata version. It would rather just happen to be the implementation used in dev/test.

@coveralls
Copy link

coveralls commented Mar 28, 2019

Pull Request Test Coverage Report for Build 851

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 91.572%

Totals Coverage Status
Change from base Build 850: 0.0%
Covered Lines: 402
Relevant Lines: 439

💛 - Coveralls

@njwest
Copy link

njwest commented Apr 30, 2019

Looks like tzdata has moved from rc to official 1.0.0 release as of April 24 @maennchen

@LostKobrakai
Copy link
Contributor Author

This is still blocked because timex does not yet allow for tzdata 1.0: bitwalker/timex#530

@maennchen
Copy link
Member

I'll try to work towards version 3. Since elixir offers all capabilities by itself, timex and calendar will no longer be needed. Therefore I'm going to merge this PR and remove all time libraries instead.

@maennchen maennchen merged commit 06e025d into quantum-elixir:master Jun 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants