Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Solution: Cleanup #354

Merged
merged 4 commits into from
Aug 12, 2018
Merged

Solution: Cleanup #354

merged 4 commits into from
Aug 12, 2018

Conversation

maennchen
Copy link
Member

@maennchen maennchen commented Aug 10, 2018 •
edited
Loading

Merge #357 first!

@maennchen maennchen requested a review from c-rack August 10, 2018 22:04
@maennchen maennchen changed the title Cleanup Solution: Cleanup Aug 10, 2018
@maennchen
Copy link
Member Author

@c-rack Please only merge if CI passes, otherwise I'll fix that issue first before merging.

@coveralls
Copy link

coveralls commented Aug 10, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 794

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+3.4%) to 86.498%
Files with Coverage Reduction New Missed Lines %
lib/quantum/normalizer.ex 1 74.07%
Totals Coverage Status
Change from base Build 789: 3.4%
Covered Lines: 205
Relevant Lines: 237
💛 - Coveralls

@maennchen
Copy link
Member Author

@c-rack This is fixing the build except for #347

@c-rack c-rack merged commit 88b14c0 into quantum-elixir:master Aug 12, 2018
@c-rack
Copy link
Member

c-rack commented Aug 12, 2018

@maennchen Thanks!

@maennchen maennchen deleted the cleanup branch August 12, 2018 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c-rack c-rack Awaiting requested review from c-rack

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maennchen @coveralls @c-rack