Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution: Implement Safer Run Strategies #352

Merged
merged 1 commit into from
Aug 10, 2018
Merged

Solution: Implement Safer Run Strategies #352

merged 1 commit into from
Aug 10, 2018

Conversation

maennchen
Copy link
Member

Merge #351 first

Fix for #312

It was quite hard to prevent BC breaks. I think it would be the time soon to think about cleaning up the code and think of a cleaner way to implement the run strategies while keeping #241 in mind.

@maennchen maennchen requested a review from c-rack August 10, 2018 21:35
@maennchen maennchen merged commit 8cf4dfc into quantum-elixir:master Aug 10, 2018
@maennchen maennchen deleted the safe_run_strategies branch August 10, 2018 21:39
@coveralls
Copy link

Pull Request Test Coverage Report for Build 786

  • 15 of 24 (62.5%) changed or added relevant lines in 5 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-1.7%) to 83.127%

Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/quantum/executor_supervisor.ex 1 2 50.0%
lib/quantum/run_strategy/all.ex 0 2 0.0%
lib/quantum/executor.ex 2 8 25.0%
Files with Coverage Reduction New Missed Lines %
lib/quantum/executor_supervisor.ex 1 60.0%
Totals Coverage Status
Change from base Build 785: -1.7%
Covered Lines: 335
Relevant Lines: 403

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants