Solution: Add helpers for querying task registry #348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 780
💛 - Coveralls |
|
Regarding doctests, maybe @maennchen could advise. |
|
@tomekowal Thanks for your PR! I wanted to specifically disable doctests for functions that can't be properly tested because of state / side effects. The default should always be true. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #344
This PR adds functions for querying task registry if specific task is running in the cluster or if any tasks are running.
I have a question about doctests. All documented functions with examples in
TaskRegistrymodule have doctests disabled. I followed what is currently there and listed the two new functions inexcept. Shall I delete doctests for this module or do you want to have them enabled and listed all functions in except?Thanks for your time reviewing the changes!