Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug in in make_combined_L_matrix: SDs for inflection not added to make_L_matrix #62

Closed
MariaHei opened this issue Apr 26, 2021 · 0 comments · Fixed by #107
Closed

Bug in in make_combined_L_matrix: SDs for inflection not added to make_L_matrix #62

MariaHei opened this issue Apr 26, 2021 · 0 comments · Fixed by #107
Labels
bug Something isn't working

Comments

@MariaHei
Copy link
Collaborator

Hi,

in make_combined_L_matrix the two parameters sd_inflection_mean and sd_inflection are not propagated to make_L_matrix. This makes it impossible to control how big the numbers are in the L and S matrices respectively.

Best,
Maria
@MariaHei MariaHei added the bug Something isn't working label Apr 8, 2024
MariaHei added a commit that referenced this issue Apr 8, 2024
@MariaHei
Fix bug in make_combined_L_matrix
960593e 
Make sure sd_inflection_mean and sd_inflection are passed on inside make_combined_L_matrix

Fixes #62
@MariaHei MariaHei mentioned this issue Apr 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix bug in make_combined_L_matrix quantling/JudiLing.jl
1 participant
@MariaHei