We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Line 69 in get_xml_type() reads:
get_xml_type()
if type(val).__name__ in ('list', 'set', 'tuple') or isinstance(val, collections.Iterable):
This is redundant. List, set and tuple types are also instances of collections.Iterable. So the line can be changed to:
if isinstance(val, collections.Iterable):
Same with line 127 in convert():
convert()
if type(obj) in (list, set, tuple) or isinstance(obj, collections.Iterable):
It can be changed to:
if isinstance(obj, collections.Iterable):
Same with line 158 in convert_dict():
convert_dict()
elif type(val) in (list, set, tuple) or isinstance(val, collections.Iterable):
elif isinstance(val, collections.Iterable):
Same with line 193 in convert_list():
convert_list()
elif type(item) in (list, set, tuple) or isinstance(item, collections.Iterable):
elif isinstance(item, collections.Iterable):
The text was updated successfully, but these errors were encountered:
v 1.6.0 fixed issue #32, duplication in test for list-like data types
2bc95ad
Fixed in version 1.6.0.
Sorry, something went wrong.
No branches or pull requests
Line 69 in
get_xml_type()
reads:This is redundant. List, set and tuple types are also instances of collections.Iterable. So the line can be changed to:
Same with line 127 in
convert()
:It can be changed to:
Same with line 158 in
convert_dict()
:It can be changed to:
Same with line 193 in
convert_list()
:It can be changed to:
The text was updated successfully, but these errors were encountered: