Skip to content

Evaluate output section end symbol assignments in partial link #624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
parth-07 wants to merge 1 commit into
base: main
Choose a base branch
from
+36 −0
Open

Evaluate output section end symbol assignments in partial link #624

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions lib/Target/GNULDBackend.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2597,6 +2597,7 @@ bool GNULDBackend::setOutputSectionOffset() {
if (isCurAlloc && cur->size())
changeSymbolsFromAbsoluteToGlobal(*out);
prev = cur;
evaluateAssignmentsAtEndOfOutputSection(*out);
++out;
}
return true;
Expand Down
3 changes: 3 additions & 0 deletions test/Common/standalone/linkerscript/PartialLinkWithOutputSectionEndAssignments/Inputs/1.c
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
extern int u1;
int foo() { return 1; }
int bar() { return u1; }
15 changes: 15 additions & 0 deletions ...Common/standalone/linkerscript/PartialLinkWithOutputSectionEndAssignments/Inputs/script.t
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
u1 = 0x100;
SECTIONS {
u2 = 0x300;
foo : {
*(.text.foo)
u3 = 0x500;
}
u4 = 0x700;
bar : {
u5 = 0x900;
*(.text.bar)
}
u5 = 0x1100;
}
u6 = 0x1300;
17 changes: 17 additions & 0 deletions ...artialLinkWithOutputSectionEndAssignments/PartialLinkWithOutputSectionEndAssignments.test
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
#---PartialLinkWithOutputSectionEndAssignments.test----- Executable,LS -----#
#BEGIN_COMMENT
# This test verifies that the linker properly evaluates the output section end
# symbol assignments when partial linking.
#END_COMMENT
#START_TEST
RUN: %clang %clangopts -o %t1.1.o %p/Inputs/1.c -c -ffunction-sections
RUN: %link %linkopts -o %t1.1.out %t1.1.o -T %p/Inputs/script.t -r
RUN: %readelf -s %t1.1.out | %filecheck %s
#END_TEST

CHECK: 100 {{.*}} u1
CHECK: 300 {{.*}} u2
CHECK: 500 {{.*}} u3
CHECK: 700 {{.*}} u4
CHECK: 1100 {{.*}} u5
CHECK: 1300 {{.*}} u6
Loading