Re-evaluate OUTSIDE_SECTIONS assignments whenever layout resets #477
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quic-seaswara
approved these changes
Oct 14, 2025
Contributor
quic-seaswara
left a comment
quic-seaswara
left a comment
There was a problem hiding this comment.
Can you pls check partial linking too ?
Contributor
Author
We don't assign addresses and evaluate assignments inside |
quic-seaswara
approved these changes
Oct 14, 2025
Contributor
quic-seaswara
left a comment
quic-seaswara
left a comment
There was a problem hiding this comment.
Please raise an issue for partial links and linker script assignments
parth-07
force-pushed
the
ReevaluateOutsideSectionsAssignment
branch
from
0216285 to
e3ed03f
Compare
parth-07
force-pushed
the
ReevaluateOutsideSectionsAssignment
branch
from
e3ed03f to
660242c
Compare
This commit updates the layout step to re-evaluate OUTSIDE_SECTIONS assignments whenever the layout is reset during layout iteration. This is important to ensure correctness of re-evaluation of SECTIONS assignments. Resolves qualcomm#468 Signed-off-by: Parth Arora <partaror@qti.qualcomm.com>
parth-07
force-pushed
the
ReevaluateOutsideSectionsAssignment
branch
from
660242c to
9a3ae5f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates the layout step to re-evaluate OUTSIDE_SECTIONS assignments whenever the layout is reset during layout iteration. This is important to ensure correctness of re-evaluation of SECTIONS assignments.
Resolves #468