[RISCV][NFC] Refactor doRelaxationQCCall #231
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit lines up the implementation fo `doRelaxationQCCall` with the implementation of relaxations for `qc.e.li`/`qc.li`. The implementation: - First checks which relaxations are possible, before trying any. - Then applies the possible relaxations in a priority order, starting with the relaxation with the smallest result, and working to relaxations with larger results. This structure makes remarking about missed relaxations a lot easier, as those messages are only emitted once the relaxation being performed has been chosen, so we also know how many bytes have been saved. The only change is the order of some error messages, and slightly higher stats about missed relaxations because now `RelaxationBytesDeleted + RelaxationBytesMissed` should stay constant despite changes to relaxation control flags if any relaxations are enabled. Signed-off-by: Sam Elliott <quic_aelliott@quicinc.com>
Member
Author
|
(I split these changes out of #201 while debugging, but they are not the problem) |
Contributor
quic-seaswara
left a comment
quic-seaswara
left a comment
There was a problem hiding this comment.
is this PR still needed ?
Can we do the required testing and we can merge this ?
Member
Author
|
I'll rebase this. It doesn't change the functionality, just some debug messages. Will make sure it is tested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit lines up the implementation fo
doRelaxationQCCallwith the implementation of relaxations forqc.e.li/qc.li.The implementation:
This structure makes remarking about missed relaxations a lot easier, as those messages are only emitted once the relaxation being performed has been chosen, so we also know how many bytes have been saved.
The only change is the order of some error messages, and slightly higher stats about missed relaxations because now
RelaxationBytesDeleted + RelaxationBytesMissedshould stay constant despite changes to relaxation control flags if any relaxations are enabled.