Skip to content

[cpullvm] Pin host compiler to clang-cl-19 for Windows Builds - #503

Open
pranav4330 wants to merge 1 commit into
qualcomm:qualcomm-softwarefrom
pranav4330:pr/host-clang-unification
Open

[cpullvm] Pin host compiler to clang-cl-19 for Windows Builds#503
pranav4330 wants to merge 1 commit into
qualcomm:qualcomm-softwarefrom
pranav4330:pr/host-clang-unification

Conversation

@pranav4330

Copy link
Copy Markdown
Contributor

Pin host compiler from generic 'clang-cl' to 'clang-cl-19', resolved from the LLVM installation pre-bundled with the GitHub=hosted windows-2025/windows-11-arm runners via the System Path.

Signed-off-by: Pranav Patil pranpati@qti.qualcomm.com

@jonathonpenix

Copy link
Copy Markdown
Contributor

Please post a link to a run of the nightlies with the Windows builds passing successfully with this change.

@jonathonpenix

Copy link
Copy Markdown
Contributor

Two late thoughts:

  • build.ps1 should also be handled as well whatever we do
  • I also wonder if this should be handled closer to what was done in fe1f2ce rather than modifying the build scripts?

@Yethendra Yethendra left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I agree with Jonathon's comment:

**I also wonder if this should be handled closer to what was done in fe1f2ce rather than modifying the build scripts? **

pranav4330 - If the builds are successful with "clang-cl-19" lets handle in install_dependencies ?

@pranav4330

Copy link
Copy Markdown
Contributor Author

Yes, I can look into that Jonathon Penix (@jonathonpenix) and Yethendra, thanks for pointing it out.

@pranav4330
pranav4330 force-pushed the pr/host-clang-unification branch from b288bfd to 9682778 Compare July 15, 2026 16:23
@jonathonpenix

Jonathon Penix (jonathonpenix) commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

The build failures should be resolved if you rebase or merge our qualcomm-software branch into yours at this point

Pin host compiler from generic 'clang-cl' to 'clang-cl-19', resolved from the LLVM installation
pre-bundled with the GitHub=hosted windows-2025/windows-11-arm runners via the System Path

Signed-off-by: Pranav Patil <pranpati@qti.qualcomm.com>

updated nightly.yml for verification

Signed-off-by: Pranav Patil <pranpati@qti.qualcomm.com>
@pranav4330
pranav4330 force-pushed the pr/host-clang-unification branch from 9682778 to a767d5a Compare July 16, 2026 23:35
@sriyalamar

Copy link
Copy Markdown
Contributor

seems current runner image spec at https://github.com/actions/runner-images/blob/main/images/windows/
│ Windows2025-Readme.md showing LLVM 20.1.8 , thats why clang-19 is not found.
If we need clang-19, in install_dependencies.ps1 — we need to add, choco install llvm --version=19.1.7 -y --force
and Copy-Item "C:\Program Files\LLVM\bin\clang-cl.exe" "C:\Program Files\LLVM\bin\clang-cl-19.exe" -Force

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants