quadric_custom_op: Handle duplicated input names #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndrego
force-pushed
the
nigel-handle-duplicated-input-names
branch
from
516dbaf to
8ffea84
Compare
ndrego
force-pushed
the
nigel-handle-duplicated-input-names
branch
from
8ffea84 to
d9b3a8e
Compare
Adhyyan1252
approved these changes
Nov 14, 2023
mgleonard425
approved these changes
Nov 14, 2023
cjm715
pushed a commit
that referenced
this pull request
Oct 16, 2024
cjm715
pushed a commit
that referenced
this pull request
Nov 21, 2024
rohan11235813
pushed a commit
that referenced
this pull request
Aug 19, 2025
rohan11235813
pushed a commit
that referenced
this pull request
Sep 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes setup of subgraph input feeds to utilize input ordering while also ensuring that the name matches. Removes
/duplicatedfrom the input name, if present. This can happen when the custom op is created before quantization.Motivation and Context