QuadricCustomOp: Handle multiple outputs when shape inferencing #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndrego
force-pushed
the
nigel-quadric-custom-shape-inference
branch
from
90b3815 to
138bb6b
Compare
mgleonard425
approved these changes
Oct 3, 2023
dfiru
approved these changes
Oct 3, 2023
veerbhan
reviewed
Oct 3, 2023
| elif node.op_type == "QuadricCustomOp": | ||
| # Should have a subgraph, but allow for cases where it's not there | ||
| subgraph = get_attribute(node, "sub_graph") | ||
| subgraphs = [subgraph] if subgraph else [] |
There was a problem hiding this comment.
What happens when there is no subgraph found in the QuadricCustomOp? Do we need to assert or let it be?
There was a problem hiding this comment.
For now we can let it be. There is some effort required to change over some old ONNXs found in TVM tests, which is why I'm letting it go for now. Since we're not currently using the subgraph for symbolic shape inference, there's no impact here.
veerbhan
approved these changes
Oct 3, 2023
ndrego
added a commit
that referenced
this pull request
Nov 10, 2023
cjm715
pushed a commit
that referenced
this pull request
Oct 16, 2024
cjm715
pushed a commit
that referenced
this pull request
Nov 21, 2024
rohan11235813
pushed a commit
that referenced
this pull request
Aug 19, 2025
rohan11235813
pushed a commit
that referenced
this pull request
Sep 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes symbolic shape inferencing for
QuadricCustomOpto handle multiple outputsMotivation and Context
Symbolic shape inferencing for
QuadricCustomOpassumed a single output