Remove internal QTS filter hooks #1176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The QTS filters come from the legacy plugin. There's no clear justification to use those in QTX. For easier maintenance remove those filters and replace them with direct calls instead. Rename validate term/post slugs as sanitize. Fix phpdoc.
spleen1981
reviewed
May 29, 2022
spleen1981
reviewed
May 29, 2022
spleen1981
reviewed
May 29, 2022
spleen1981
reviewed
May 29, 2022
|
Reverted the empty string checks. It should never be |
spleen1981
approved these changes
May 29, 2022
herrvigg
added a commit
that referenced
this pull request
May 29, 2022
The QTS filters come from the legacy plugin: - filter: `qts_validate_post_slug` - filter: `qts_validate_term_slug` - filter: `qts_permastruct` - filter: `qts_url_args` For easier maintenance and readability, remove those filters and replace them with direct calls instead. New `qtranslate` filters will be added on request if the need is justified. Rename the two `validate` slugs functions to `sanitize` (post/term). Minor cleanup to improve phpdoc and code readability.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The QTS filters come from the legacy plugin:
qts_validate_post_slugqts_validate_term_slugqts_permastructqts_url_argsFor easier maintenance and readability, remove those filters and replace them with direct calls instead.
New
qtranslatefilters will be added on request if the need is justified.Rename the two
validateslugs functions tosanitize(post/term).Minor cleanup to improve phpdoc and code readability.