QTS: fix to handle esc_sql() 4.8.3 breaking change #1157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since 4.8.3, ‘%’ characters will be replaced with a placeholder string with esc_sql(). This fix replaces back the placeholder to ‘%’ after esc_sql() call to retain the original behaviour.
herrvigg
reviewed
May 1, 2022
| @@ -957,6 +957,7 @@ private function get_page_id_by_path( $page_path, $output = OBJECT, $post_type = | |||
| $page_path = str_replace( '%20', ' ', $page_path ); | |||
| $parts = explode( '/', trim( $page_path, '/' ) ); | |||
| $parts = array_map( 'esc_sql', $parts ); | |||
| $parts = array_map( array( $wpdb, 'remove_placeholder_escape' ), $parts ); | |||
| $parts = array_map( 'sanitize_title_for_query', $parts ); | |||
There was a problem hiding this comment.
The 3x array_map may be regrouped in one function (even anonymous) for faster execution in a sngle array_map.
herrvigg
approved these changes
May 2, 2022
This was referenced Apr 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since 4.8.3, ‘%’ characters will be replaced with a placeholder string with esc_sql().
This fix replaces back the placeholder to ‘%’ after esc_sql() call to retain the original behaviour.