Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix "Headers already sent" error in PHP #1114

Merged
merged 2 commits into from
Feb 23, 2022
Merged

fix "Headers already sent" error in PHP #1114

merged 2 commits into from
Feb 23, 2022

Conversation

picasso
Copy link
Contributor

@picasso picasso commented Feb 22, 2022

setcookie is function modifying the HTTP header (need to send a Set-Cookie:)
sometimes wp_cron.php seems to be the source of headers being sent prematurely
so we avoid setting the cookie during wp_doing_cron if the headers have already been sent (it's painless for the plugin to skip this)

@herrvigg herrvigg added the core Core functionalities, including the admin section label Feb 22, 2022
herrvigg
herrvigg reviewed Feb 23, 2022
View reviewed changes
qtranslate_core.php Outdated Show resolved Hide resolved
@herrvigg
Copy link
Collaborator

See also #779.

@herrvigg herrvigg merged commit f05b769 into qtranslate:master Feb 23, 2022
@herrvigg herrvigg mentioned this pull request Feb 23, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@herrvigg herrvigg herrvigg left review comments

@sviluppomania sviluppomania sviluppomania approved these changes

Assignees
No one assigned
Labels
core Core functionalities, including the admin section
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@picasso @herrvigg @sviluppomania @dmitriy-rudakov