Skip to content

Conversation

@77nnit
Copy link
Contributor

@77nnit 77nnit commented Nov 3, 2024

New script to publish markdown notes to GoToSocial activitypub server.

77nnit and others added 20 commits October 31, 2024 16:32
the `l` got lost in the `.qml` extension...
Build was failing for inconsistent identifier
Removed Linux and MacOs as not tested
regression bug due to changing identifier
Enhancement: style selector
Enhancement: separator selector

	modified:   ascii-tree-factory/ASCII-Tree-Factory.qml
	modified:   ascii-tree-factory/info.json
	modified:   ascii-tree-factory/readme.md
	renamed:    ascii-tree-factory/ASCII-Tree-Factory.qml -> ascii-tree-factory/ascii-tree-factory.qml
	modified:   ascii-tree-factory/readme.md
@@ -0,0 +1,10 @@
{
"name": "Publish to GtS",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you maybe please use "GoToSocial" instead of "GtS" as name?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, will do

"identifier": "authCode",
"name": "Authentication Code",
"description": "Code returned by GtS after performing a successful authentication, if you paste it here you won't need to authenticate again until expiry",
"type": "string",
Copy link
Member

@pbek pbek Nov 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to consider string-secret from pbek/QOwnNotes#3150?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to update minAppVersion too if you use the string-secret.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the next iteration will be with string -secret.

@pbek
Copy link
Member

pbek commented Nov 4, 2024

It would make sense if you rebase your local git repo to master, you are pushing all your past commits to this pull request again. 😉

"platforms": ["linux"],
"version": "0.1.0",
"minAppVersion": "24.10.5",
"description" : "Publish To GtS lets you publish your notes to your GoToSocial account."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe link the name GoToSocial to https://gotosocial.org/?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure

@77nnit
Copy link
Contributor Author

77nnit commented Nov 4, 2024

It would make sense if you rebase your local git repo to master, you are pushing all your past commits to this pull request again. 😉

I realized it as soon as I created the pull request. I'm sorry for all these inconveniences, but I'm slowly learning GIT mechanics... not ye used to them!

@77nnit
Copy link
Contributor Author

77nnit commented Nov 4, 2024

Should I close this Pull request, adjust things and open a new one? Wouldn't it be cleaner?

@pbek
Copy link
Member

pbek commented Nov 4, 2024

Should I close this Pull request, adjust things and open a new one? Wouldn't it be cleaner?

No, not needed. I'll just squash the commits.

@pbek pbek merged commit 819bbd0 into qownnotes:master Nov 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants