Skip to content

Conversation

@diegovskytl
Copy link
Contributor

This script is for those who activate the option "Allow note name to be different than title" to choose the file name and file title through a pop up dialog window, instead of having to rightclick the note.

It has a checkbox for the user to choose between 2 options:

  • one dialog window input defines both note name and title
  • Note name and note title have separate pop ups, making it easy to be different from the other.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please remove the .DS_Store? 😉

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@pbek
Copy link
Member

pbek commented Aug 10, 2024

I think there are two problems with the script:

@diegovskytl diegovskytl marked this pull request as draft August 10, 2024 05:41
@diegovskytl
Copy link
Contributor Author

I think there are two problems with the script:

No problem here ;) in line 61 there is an early return that checks if the file has just been created. Only if it is the case, the dialog will show!

  • Keep in mind that you have to care about duplicate names yourself when using this script! I guess so far it is possible that you overwrite already present notes.

In the next version I will include some overwrite protection :)

@diegovskytl diegovskytl marked this pull request as ready for review August 10, 2024 05:55
@diegovskytl
Copy link
Contributor Author

Tell me if you would like a pull request with less commits 🫨

@pbek
Copy link
Member

pbek commented Aug 10, 2024

Tell me if you would like a pull request with less commits 🫨

If you can squash your commits and do a force push to your branch it would be great! 😉

@diegovskytl
Copy link
Contributor Author

If you can squash your commits and do a force push to your branch it would be great! 😉

Done :)

@pbek pbek merged commit f156c1d into qownnotes:master Aug 11, 2024
@pbek
Copy link
Member

pbek commented Aug 11, 2024

Great, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants