Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rector assisted update to PHP 8.1 #953

Merged
merged 9 commits into from
Sep 7, 2022
Merged

Rector assisted update to PHP 8.1 #953

merged 9 commits into from
Sep 7, 2022

Conversation

patrickkusebauch
Copy link
Collaborator

@patrickkusebauch patrickkusebauch commented Aug 12, 2022

The first 2 commits are done by https://github.com/rectorphp/rector. The rest are manual fixes.

@patrickkusebauch patrickkusebauch marked this pull request as draft August 12, 2022 16:27
@patrickkusebauch
Copy link
Collaborator Author

Almost done. I want to take a stab at InheritDependency skipped violation. :)

So far 800 deleted lines of code we could afford with PHP 8.1

@patrickkusebauch patrickkusebauch marked this pull request as ready for review August 12, 2022 21:35
@dbrumann dbrumann merged commit 62031d3 into qossmic:main Sep 7, 2022
@patrickkusebauch patrickkusebauch deleted the feature/update branch November 23, 2022 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants