Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement: Enable static_lambda fixer #254

Merged
merged 2 commits into from
Aug 19, 2019
Merged

Enhancement: Enable static_lambda fixer #254

merged 2 commits into from
Aug 19, 2019

Conversation

localheinz
Copy link
Contributor

@localheinz localheinz commented Aug 18, 2019 •
edited
Loading

This PR

  • enables the static_lambda fixer
  • runs php-cs-fixer

💁‍♂ For reference, see https://github.com/FriendsOfPHP/PHP-CS-Fixer/tree/v2.15.1#usage:

static_lambda

Lambdas not (indirect) referencing $this must be declared static.

Risky rule: risky when using ->bindTo on lambdas without referencing to $this.

@smoench
Copy link
Contributor

smoench commented Aug 19, 2019

@localheinz This PR needs a rebase and/or rerun of php-cs-fixer against latest master :-)

@localheinz
Copy link
Contributor Author

@smoench

Rebased!

@smoench smoench merged commit 6569532 into qossmic:master Aug 19, 2019
@smoench
Copy link
Contributor

smoench commented Aug 19, 2019

Thank you, @localheinz!

@localheinz localheinz deleted the feature/static-lambda branch August 19, 2019 08:14
@localheinz
Copy link
Contributor Author

Thank you, @smoench!

@smoench smoench added this to the 0.6 milestone Sep 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.6
Development

Successfully merging this pull request may close these issues.
2 participants
@localheinz @smoench