Fixes location information in JDK14LoggerAdapter
#439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `JDK14LoggerAdapter` class uses the wrong caller boundary for location unaware methods. This PR: - Sets the correct caller boundary for classic API method calls (`AbstractLogger`), - Adds the missing `LoggingEventAware` interface and fixes its implementation. The interface was previously implemented, but not declared. - Adds a test for qos-ch#425. The `SubstituteLogger` tests depend on qos-ch#438. Signed-off-by: Piotr P. Karwasz <piotr.github@karwasz.org>
ppkarwasz
force-pushed
the
fix/jdk14-location
branch
from
acbca00 to
4dd1486
Compare
|
I am converting this to draft, since it requires #438. |
Theschorpioen
approved these changes
Dec 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
JDK14LoggerAdapterclass uses the wrong caller boundary for location unaware methods.This PR:
AbstractLogger),LoggingEventAwareinterface and fixes its implementation. The interface was previously implemented, but not declared.The
SubstituteLoggertests depend on #438.