-
Notifications
You must be signed in to change notification settings - Fork 12
Deprecate equal_bases
#41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #41 +/- ##
==========================================
- Coverage 33.91% 32.58% -1.33%
==========================================
Files 13 14 +1
Lines 401 402 +1
==========================================
- Hits 136 131 -5
- Misses 265 271 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
adding myself as a reviewer for after #37 is done |
21d52be to
4e26c1d
Compare
|
@Krastanov I'm breaking off deprecating |
|
The breakage in QuantumOpticsBase is to be expected given the change. We will need to keep it in mind for a while. |
Reopening #39 here, I guess github doesn't allow reopening a PR after the branch has been force pushed. The actual Pauli operator basis will have a different structure than the currently named PauliBasis. Having a deprecation warning now would be good so give users a chance to realize this. Later, when introducing the actual Pauli operator basis, this allows us the chance to use the PauliBasis name for the actual Pauli operator basis.