Skip to content

Conversation

@akirakyle
Copy link
Member

Reopening #39 here, I guess github doesn't allow reopening a PR after the branch has been force pushed. The actual Pauli operator basis will have a different structure than the currently named PauliBasis. Having a deprecation warning now would be good so give users a chance to realize this. Later, when introducing the actual Pauli operator basis, this allows us the chance to use the PauliBasis name for the actual Pauli operator basis.

@codecov
Copy link

codecov bot commented Dec 9, 2024

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Project coverage is 32.58%. Comparing base (8407cc3) to head (f607ed6).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/deprecated.jl 0.00% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #41      +/-   ##
==========================================
- Coverage   33.91%   32.58%   -1.33%     
==========================================
  Files          13       14       +1     
  Lines         401      402       +1     
==========================================
- Hits          136      131       -5     
- Misses        265      271       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Krastanov
Copy link
Member

adding myself as a reviewer for after #37 is done

@akirakyle akirakyle force-pushed the deprecate branch 3 times, most recently from 21d52be to 4e26c1d Compare April 5, 2025 22:00
@akirakyle akirakyle marked this pull request as draft April 6, 2025 00:14
@akirakyle akirakyle marked this pull request as ready for review April 6, 2025 17:33
@akirakyle akirakyle changed the title Deprecate PauliBasis and equal_bases Deprecate equal_bases Apr 6, 2025
@akirakyle
Copy link
Member Author

@Krastanov I'm breaking off deprecating PauliBasis into another PR so we can focus discussion there on just that and so it's easier to review. This is ready for review now!

@Krastanov
Copy link
Member

The breakage in QuantumOpticsBase is to be expected given the change. We will need to keep it in mind for a while.

@Krastanov Krastanov merged commit b3be671 into qojulia:main Apr 20, 2025
9 of 12 checks passed
@akirakyle akirakyle deleted the deprecate branch April 20, 2025 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants