[CORRUPTED] Synthetic Benchmark PR #14543 - Add kvstore type and decouple kvstore from its metadata#24
Open
bar-qodo wants to merge 9 commits intobase_pr_14543_20260113_3578from
Open
Conversation
This was referenced Jan 14, 2026
Open
Open
Open
Open
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Benchmark PR redis#14543
Type: Corrupted (contains bugs)
Original PR Title: Add kvstore type and decouple kvstore from its metadata
Original PR Description: Decouple kvstore from its metadata by introducing
kvstoreTypestructure ofcallbacks. This resolves the abstraction layer violation of having kvstore
include
server.hdirectly.Move (again) cluster slot statistics to per slot dicts' metadata. The callback
canFreeDictis used to prevent freeing empty per slot dicts from losing perslot statistics.
Co-authored-by: Ran Tidhar ran.tidhar@redis.com
Original PR URL: redis#14543