Skip to content

[CORRUPTED] Synthetic Benchmark PR #19997 - feat(ui-v2): Add trigger form templates#569

Open
tomerqodo wants to merge 3 commits intobase_pr_19997_20260121_5171from
corrupted_pr_19997_20260121_5171
Open

[CORRUPTED] Synthetic Benchmark PR #19997 - feat(ui-v2): Add trigger form templates#569
tomerqodo wants to merge 3 commits intobase_pr_19997_20260121_5171from
corrupted_pr_19997_20260121_5171

Conversation

@tomerqodo
Copy link

Benchmark PR PrefectHQ#19997

Type: Corrupted (contains bugs)

Original PR Title: feat(ui-v2): Add trigger form templates
Original PR Description: Implements Phase 4 of the trigger form templates for the automations wizard, replacing placeholder "coming soon" messages with functional form components for the remaining 4 trigger types.

Changes

This PR adds 4 new trigger field components that follow the same pattern as the existing FlowRunStateTriggerFields:

  • DeploymentStatusTriggerFields: Select dropdown with Ready/Not Ready status options
  • WorkPoolStatusTriggerFields: Select dropdown with Ready/Not Ready/Paused status options
  • WorkQueueStatusTriggerFields: Select dropdown with Ready/Not Ready/Paused status options
  • CustomTriggerFields: Textarea for entering expected events (one per line)

All components include:

  • PostureSelect for Reactive/Proactive toggle
  • Threshold input field
  • Conditional "Within (seconds)" field shown only when posture is Proactive

Screenshot

Deployment Status Trigger Fields

Review Focus

  • Verify the hardcoded status event names (e.g., prefect.deployment.ready) match backend expectations
  • Custom trigger textarea converts newline-separated text to/from string array - verify this behavior is correct
  • Status triggers store selected value as single-element array per requirements

closes OSS-7417

Checklist

  • This pull request references any related issue by including "closes <link to issue>"
  • If this pull request adds new functionality, it includes unit tests that cover the changes
  • If this pull request removes docs files, it includes redirect settings in mint.json.
  • If this pull request adds functions or classes, it includes helpful docstrings.

Link to Devin run: https://app.devin.ai/sessions/5c547ac1154646648315fefae73b003f
Requested by: alex.s@prefect.io (@desertaxle)
Original PR URL: PrefectHQ#19997

devin-ai-integration bot and others added 3 commits January 21, 2026 15:47
…ool-status, work-queue-status, and custom triggers

- Create DeploymentStatusTriggerFields component with status select
- Create WorkPoolStatusTriggerFields component with status select
- Create WorkQueueStatusTriggerFields component with status select
- Create CustomTriggerFields component with textarea for expected events
- Update TriggerStep to use new components instead of placeholders
- Export all new components from index.ts

All components follow the same pattern as FlowRunStateTriggerFields with:
- PostureSelect for Reactive/Proactive toggle
- Threshold input field
- Conditional Within field (shown only for Proactive posture)

Co-Authored-By: alex.s@prefect.io <ajstreed1@gmail.com>
…mponents

Update tests to check for actual component rendering instead of placeholder
text now that the trigger form templates are implemented.

Co-Authored-By: alex.s@prefect.io <ajstreed1@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant