[CLEAN] Synthetic Benchmark PR #20209 - Add block document reference support to schema form#556
Open
tomerqodo wants to merge 1 commit intobase_pr_20209_20260121_2618from
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Benchmark PR PrefectHQ#20209
Type: Clean (correct implementation)
Original PR Title: Add block document reference support to schema form
Original PR Description: Implements block document reference support for schema form properties. When a schema property has a
blockTypeSlugfield, it now renders a block document selector with optional inline creation instead of throwing a "not implemented" error.This adds three new components:
{ $ref: blockDocumentId }formatThe integration in
schema-form-input.tsxreplaces the previousthrow new Error("not implemented")with the new component.Related to PrefectHQ#15512
Updates since last revision
reactQueryDecoratortoproperties.stories.tsxto fix Storybook error for blockTypeSlug stories (they require QueryClientProvider for TanStack Query)Screenshots
Human Review Checklist
{ $ref: blockDocumentId }format is the correct structure for block document references in Prefect schemasschema-form-input.tsx(line 82) castsvalue as { $ref: string } | undefined- confirm this is safeas unknown as PrefectSchemaObjectcast inblock-document-create-dialog.tsxforblockSchema.fields- confirm this is safelike_in API query) and client-side filtering (filteredData) - this may be redundantChecklist
<link to issue>"mint.json.Link to Devin run: https://app.devin.ai/sessions/36e0160cacd7477db78917771f4b27f4
Requested by: @desertaxle
Original PR URL: PrefectHQ#20209