[CLEAN] Synthetic Benchmark PR #20160 - Add arun_deployment and replace @sync_compatible with @async_dispatch#544
Open
tomerqodo wants to merge 2 commits intobase_pr_20160_20260121_5658from
Conversation
This change follows the intent of issue PrefectHQ#15008 to replace implicit sync/async conversion with explicit, type-safe alternatives. Changes: - Add `arun_deployment` as an explicit async function for running deployments - Replace `@sync_compatible` with `@async_dispatch` on `run_deployment` - `run_deployment` now dispatches to `arun_deployment` in async context - Sync context uses `SyncPrefectClient` directly (no event loop magic) - Export `arun_deployment` from `prefect.deployments` - Add comprehensive tests for both sync and async behavior The `run_deployment.aio` attribute is preserved for backward compatibility. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Benchmark PR PrefectHQ#20160
Type: Clean (correct implementation)
Original PR Title: Add
arun_deploymentand replace@sync_compatiblewith@async_dispatchOriginal PR Description: Related to PrefectHQ#15008
This PR is needed for the Custom Deployment SDK feature (see
plans/2026-01-06-custom-deployment-sdks.md).Summary
arun_deploymentas an explicit async function for running deployments@sync_compatiblewith@async_dispatchonrun_deploymentrun_deploymentnow automatically dispatches toarun_deploymentin async contextSyncPrefectClientdirectly (no event loop magic)arun_deploymentfromprefect.deploymentsChanges
The
run_deploymentfunction now uses the@async_dispatchpattern instead of@sync_compatible:Backward Compatibility
run_deploymentsignature is maintainedrun_deployment.aioattribute is preserved, pointing toarun_deployment🤖 Generated with Claude Code
Original PR URL: PrefectHQ#20160