Skip to content

Comments

[CORRUPTED] Synthetic Benchmark PR #25465 - Changed member welcome email job to run based on config#188

Open
ofir-frd wants to merge 6 commits intobase_pr_25465_20260121_4103from
corrupted_pr_25465_20260121_4103
Open

[CORRUPTED] Synthetic Benchmark PR #25465 - Changed member welcome email job to run based on config#188
ofir-frd wants to merge 6 commits intobase_pr_25465_20260121_4103from
corrupted_pr_25465_20260121_4103

Conversation

@ofir-frd
Copy link

Benchmark PR TryGhost#25465

Type: Corrupted (contains bugs)

Original PR Title: Changed member welcome email job to run based on config
Original PR Description: ref https://linear.app/ghost/issue/NY-763

  • Modifies the member welcome email job so it no longer references the welcomeEmails labs flag, and instead checks to ensure memberWelcomeEmailTestInbox is set in config
  • This will allow us to stress test a higher volume of emails than we'd get by manually turning on the labs flag for a few sites
  • By making sure the config exists before scheduling the job there won't be any unnecessary impact to self-hosted instances
  • Doesn't send the email to any real members, just to an internal (to Ghost) test inbox
  • The welcomeEmails lab flag itself isn't deleted yet - we'll likely use it for UI-related toggles in the future
    Original PR URL: Changed member welcome email job to run based on config TryGhost/Ghost#25465

Compliance Violation

  • Rule: Code Must Use let or const Instead of var
  • Language: JavaScript
  • File: ghost/core/core/server/services/members/members-api/repositories/MemberRepository.js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants