Align zh translations with China mainland terminology.#46
Conversation
WalkthroughChinese localization updates across three files: deletion of the comments.json locale file and refinement of translation strings in ghost.json and portal.json to improve terminology consistency, phrasing clarity, and natural language expression. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Fix all issues with AI agents
In `@ghost/i18n/locales/zh/portal.json`:
- Line 9: The Chinese translation for the key "{memberEmail} will no longer
receive {newsletterName} newsletter." removes the {newsletterName} placeholder;
update the value so it preserves the placeholder (e.g. include {newsletterName}
in the translated string) and keep surrounding punctuation/spacing intact so the
runtime interpolation can insert the newsletter name correctly.
- Around line 116-117: The translation for the JSON key "Name" ("Name": "名称") is
inconsistent with nearby copy ("输入您的名字"); update the value for the "Name" key to
use the consistent term (e.g., "名字" or "姓名") so it matches surrounding UI text
and tone—modify the value string for "Name" accordingly.
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
ghost/i18n/locales/zh/comments.jsonghost/i18n/locales/zh/ghost.jsonghost/i18n/locales/zh/portal.json
💤 Files with no reviewable changes (1)
- ghost/i18n/locales/zh/comments.json
🔇 Additional comments (11)
ghost/i18n/locales/zh/ghost.json (2)
6-6: Terminology updates look good.These phrasing changes read naturally for mainland usage and keep placeholders intact.
Also applies to: 27-31, 39-40, 48-48
78-81: Subscription status wording is clear and consistent.The single-sentence phrasing is concise and user-friendly.
ghost/i18n/locales/zh/portal.json (9)
58-58: Preference-management phrasing reads well.
63-63: These UI labels are clean and consistent.Also applies to: 85-85, 90-90
108-108: Content preference label is clear.
124-124: Guidance text is fluent and clear.
176-176: Invite-only phrasing is appropriate.
192-195: Unsubscribe wording is consistent.
199-199: Verification prompt reads naturally.
212-214: Email-delivery status messaging is clear.
218-218: Resubscribe failure message is clear.
✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.
| "{amount} off forever.": "永久减免{amount}", | ||
| "{discount}% discount": "{discount}% 折扣", | ||
| "{memberEmail} will no longer receive {newsletterName} newsletter.": "{memberEmail}将不会再收到{newsletterName}的新闻信。", | ||
| "{memberEmail} will no longer receive {newsletterName} newsletter.": "{memberEmail}将不会再收到新闻信。", |
There was a problem hiding this comment.
Preserve the {newsletterName} placeholder.
The translation drops the newsletter name, which removes key context. Consider keeping the placeholder in Chinese.
✅ Suggested fix
- "{memberEmail} will no longer receive {newsletterName} newsletter.": "{memberEmail}将不会再收到新闻信。",
+ "{memberEmail} will no longer receive {newsletterName} newsletter.": "{memberEmail}将不会再收到{newsletterName}新闻信。",📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "{memberEmail} will no longer receive {newsletterName} newsletter.": "{memberEmail}将不会再收到新闻信。", | |
| "{memberEmail} will no longer receive {newsletterName} newsletter.": "{memberEmail}将不会再收到{newsletterName}新闻信。", |
🤖 Prompt for AI Agents
In `@ghost/i18n/locales/zh/portal.json` at line 9, The Chinese translation for the
key "{memberEmail} will no longer receive {newsletterName} newsletter." removes
the {newsletterName} placeholder; update the value so it preserves the
placeholder (e.g. include {newsletterName} in the translated string) and keep
surrounding punctuation/spacing intact so the runtime interpolation can insert
the newsletter name correctly.
| "More like this": "更多类似内容", | ||
| "Name": "名称", |
There was a problem hiding this comment.
Align “Name” with nearby copy.
The label “名称” feels inconsistent with “输入您的名字”. Consider using “名字” (or “姓名”) for consistency.
✅ Suggested fix
- "Name": "名称",
+ "Name": "名字",📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "More like this": "更多类似内容", | |
| "Name": "名称", | |
| "More like this": "更多类似内容", | |
| "Name": "名字", |
🤖 Prompt for AI Agents
In `@ghost/i18n/locales/zh/portal.json` around lines 116 - 117, The translation
for the JSON key "Name" ("Name": "名称") is inconsistent with nearby copy
("输入您的名字"); update the value for the "Name" key to use the consistent term
(e.g., "名字" or "姓名") so it matches surrounding UI text and tone—modify the value
string for "Name" accordingly.
1 participant
Benchmark PR from agentic-review-benchmarks#8
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.