Skip to content

Comments

Align zh translations with China mainland terminology.#32

Open
tomerqodo wants to merge 2 commits intocoderabbit_combined_20260121_augment_sentry_coderabbit_1_base_align_zh_translations_with_china_mainland_terminology_pr222from
coderabbit_combined_20260121_augment_sentry_coderabbit_1_head_align_zh_translations_with_china_mainland_terminology_pr222
Open

Align zh translations with China mainland terminology.#32
tomerqodo wants to merge 2 commits intocoderabbit_combined_20260121_augment_sentry_coderabbit_1_base_align_zh_translations_with_china_mainland_terminology_pr222from
coderabbit_combined_20260121_augment_sentry_coderabbit_1_head_align_zh_translations_with_china_mainland_terminology_pr222

Conversation

@tomerqodo
Copy link

@tomerqodo tomerqodo commented Jan 21, 2026

Benchmark PR from qodo-benchmark#222

Summary by CodeRabbit

Localization

  • Updated Chinese translations throughout the platform for improved consistency and clarity, including subscription messaging, UI labels, and terminology refinement
  • Improved wording and tone in Chinese-language interfaces for a better user experience

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Jan 21, 2026

Walkthrough

Three Chinese locale files were modified to refine translations: one comments translation file was deleted, and two others (ghost.json and portal.json) received updated Chinese translations for UI strings including subscription messages, newsletter text, and portal labels. No logic or control flow changes were introduced.

Changes

Cohort / File(s) Summary
Deleted Chinese Comments Locale
ghost/i18n/locales/zh/comments.json
Removed entire file containing Chinese translations for comments UI (actions, statuses, timestamps, prompts). Previously mapped 74 lines of English-to-Chinese strings.
Updated Chinese Core Locale
ghost/i18n/locales/zh/ghost.json
Refined 13 Chinese translations including: "Comment" (留言 → 评论), subscription-related messages (会籍 → 订阅 terminology), UI labels ("Name", "Less like this", "More like this", "Manage subscription"), and timestamps ("See you soon!", "Sent to {email}").
Updated Chinese Portal Locale
ghost/i18n/locales/zh/portal.json
Revised 17 translation strings for wording/tone across newsletter notices, email settings, site access messages, and UI labels. Adjusted phrasing, punctuation, and sentence structure in Chinese.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A whisper through the lands so far,
Where Chinese characters shine like a star,
Comments take flight, translations refined,
Subscriptions and newsletters, all realigned!
From 留言 to 评论, the words dance with care,
Our locales renewed, with precision so rare!

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Align zh translations with China mainland terminology' directly and clearly describes the main change—updating Chinese translations to match mainland China terminology standards.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In `@ghost/i18n/locales/zh/portal.json`:
- Line 9: The translated string for the source key "{memberEmail} will no longer
receive {newsletterName} newsletter." removed the {newsletterName} placeholder;
update the translation value to include the exact placeholder {newsletterName}
(e.g. "{memberEmail} 将不会再收到 {newsletterName} 新闻信。") so the placeholder name
matches the source and i18n validation stays intact.
📜 Review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ae1cefa and f63ce8a.

📒 Files selected for processing (3)
  • ghost/i18n/locales/zh/comments.json
  • ghost/i18n/locales/zh/ghost.json
  • ghost/i18n/locales/zh/portal.json
💤 Files with no reviewable changes (1)
  • ghost/i18n/locales/zh/comments.json
🔇 Additional comments (2)
ghost/i18n/locales/zh/portal.json (1)

58-58: Translations look consistent with updated terminology and tone.

No issues spotted in these updates.

Also applies to: 63-63, 85-85, 90-90, 108-108, 116-117, 124-124, 176-176, 192-192, 194-194, 199-199, 212-214, 218-218

ghost/i18n/locales/zh/ghost.json (1)

6-6: Terminology updates are consistent and placeholders are preserved.

Looks good.

Also applies to: 27-31, 39-40, 48-48, 78-81

✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.

"{amount} off forever.": "永久减免{amount}",
"{discount}% discount": "{discount}% 折扣",
"{memberEmail} will no longer receive {newsletterName} newsletter.": "{memberEmail}将不会再收到{newsletterName}的新闻信。",
"{memberEmail} will no longer receive {newsletterName} newsletter.": "{memberEmail}将不会再收到新闻信。",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

Preserve {newsletterName} placeholder in translation.

Line 9 drops {newsletterName}, which will either lose the newsletter context or break placeholder validation in i18n tooling.

✅ Suggested fix
-    "{memberEmail} will no longer receive {newsletterName} newsletter.": "{memberEmail}将不会再收到新闻信。",
+    "{memberEmail} will no longer receive {newsletterName} newsletter.": "{memberEmail}将不会再收到{newsletterName}新闻信。",
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
"{memberEmail} will no longer receive {newsletterName} newsletter.": "{memberEmail}将不会再收到新闻信",
"{memberEmail} will no longer receive {newsletterName} newsletter.": "{memberEmail}将不会再收到{newsletterName}新闻信",
🤖 Prompt for AI Agents
In `@ghost/i18n/locales/zh/portal.json` at line 9, The translated string for the
source key "{memberEmail} will no longer receive {newsletterName} newsletter."
removed the {newsletterName} placeholder; update the translation value to
include the exact placeholder {newsletterName} (e.g. "{memberEmail} 将不会再收到
{newsletterName} 新闻信。") so the placeholder name matches the source and i18n
validation stays intact.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant