Align zh translations with China mainland terminology.#32
Conversation
WalkthroughThree Chinese locale files were modified to refine translations: one comments translation file was deleted, and two others (ghost.json and portal.json) received updated Chinese translations for UI strings including subscription messages, newsletter text, and portal labels. No logic or control flow changes were introduced. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@ghost/i18n/locales/zh/portal.json`:
- Line 9: The translated string for the source key "{memberEmail} will no longer
receive {newsletterName} newsletter." removed the {newsletterName} placeholder;
update the translation value to include the exact placeholder {newsletterName}
(e.g. "{memberEmail} 将不会再收到 {newsletterName} 新闻信。") so the placeholder name
matches the source and i18n validation stays intact.
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
ghost/i18n/locales/zh/comments.jsonghost/i18n/locales/zh/ghost.jsonghost/i18n/locales/zh/portal.json
💤 Files with no reviewable changes (1)
- ghost/i18n/locales/zh/comments.json
🔇 Additional comments (2)
ghost/i18n/locales/zh/portal.json (1)
58-58: Translations look consistent with updated terminology and tone.No issues spotted in these updates.
Also applies to: 63-63, 85-85, 90-90, 108-108, 116-117, 124-124, 176-176, 192-192, 194-194, 199-199, 212-214, 218-218
ghost/i18n/locales/zh/ghost.json (1)
6-6: Terminology updates are consistent and placeholders are preserved.Looks good.
Also applies to: 27-31, 39-40, 48-48, 78-81
✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.
| "{amount} off forever.": "永久减免{amount}", | ||
| "{discount}% discount": "{discount}% 折扣", | ||
| "{memberEmail} will no longer receive {newsletterName} newsletter.": "{memberEmail}将不会再收到{newsletterName}的新闻信。", | ||
| "{memberEmail} will no longer receive {newsletterName} newsletter.": "{memberEmail}将不会再收到新闻信。", |
There was a problem hiding this comment.
Preserve {newsletterName} placeholder in translation.
Line 9 drops {newsletterName}, which will either lose the newsletter context or break placeholder validation in i18n tooling.
✅ Suggested fix
- "{memberEmail} will no longer receive {newsletterName} newsletter.": "{memberEmail}将不会再收到新闻信。",
+ "{memberEmail} will no longer receive {newsletterName} newsletter.": "{memberEmail}将不会再收到{newsletterName}新闻信。",📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "{memberEmail} will no longer receive {newsletterName} newsletter.": "{memberEmail}将不会再收到新闻信。", | |
| "{memberEmail} will no longer receive {newsletterName} newsletter.": "{memberEmail}将不会再收到{newsletterName}新闻信。", |
🤖 Prompt for AI Agents
In `@ghost/i18n/locales/zh/portal.json` at line 9, The translated string for the
source key "{memberEmail} will no longer receive {newsletterName} newsletter."
removed the {newsletterName} placeholder; update the translation value to
include the exact placeholder {newsletterName} (e.g. "{memberEmail} 将不会再收到
{newsletterName} 新闻信。") so the placeholder name matches the source and i18n
validation stays intact.
Benchmark PR from qodo-benchmark#222
Summary by CodeRabbit
Localization
✏️ Tip: You can customize this high-level summary in your review settings.