Align zh translations with China mainland terminology.#19
Conversation
WalkthroughChinese localization files updated to improve translation quality and consistency. The comments locale file was removed entirely, while ghost.json and portal.json received translation refinements including terminology adjustments (订阅 vs 会籍), clearer UI/UX messaging, and enhanced readability for error and status messages. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@ghost/i18n/locales/zh/portal.json`:
- Line 9: The translation for the key "{memberEmail} will no longer receive
{newsletterName} newsletter." is missing the {newsletterName} placeholder;
update the Chinese value to include the placeholder (e.g. "{memberEmail} 将不会再收到
{newsletterName} 新闻信。") so the rendered message shows which newsletter was
unsubscribed from and keep the placeholder exactly as `{newsletterName}` and
`{memberEmail}` to preserve interpolation.
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
ghost/i18n/locales/zh/comments.jsonghost/i18n/locales/zh/ghost.jsonghost/i18n/locales/zh/portal.json
💤 Files with no reviewable changes (1)
- ghost/i18n/locales/zh/comments.json
🔇 Additional comments (6)
ghost/i18n/locales/zh/ghost.json (2)
6-6: LGTM! Translation improvements look appropriate.The terminology changes align well with mainland China conventions:
- "评论" is the standard term for "Comment"
- "减少此类内容" / "更多类似内容" are natural translations for content preference controls
- "管理订阅" and "订阅详情" consistently use 订阅 terminology
Also applies to: 27-31
78-81: Subscription status translations are consistent and clear.The shift from "会籍" to "订阅" terminology aligns with common mainland China usage for subscription-based services.
Minor observation: Line 81 uses "更新" for "renew" — while "续订" is more precise for subscription renewal, "更新" is commonly understood and acceptable in this context.
ghost/i18n/locales/zh/portal.json (4)
117-117: Verify intentional difference in "Name" translation between files.This file uses "名称" for "Name" while
ghost.json(line 31) uses "名字". Both are valid but have slightly different connotations:
- "名字" = personal name (more personal/casual)
- "名称" = name/title (more formal/general)
If these fields serve different purposes (e.g., personal profile vs. general label), the difference is appropriate. Otherwise, consider aligning for consistency.
58-58: LGTM! UI string refinements improve clarity.The rephrased messages are more natural in Chinese:
- Line 58: Preference management prompt flows naturally
- Line 63: "新闻信设置已更新" is concise and clear
- Line 90: "联系我们获取帮助" is a clear call to action
Also applies to: 63-63, 90-90
192-194: LGTM! Email-related message translations are accurate.The email notification state messages are clear and maintain proper distinctions:
- "取消接收" appropriately conveys the unsubscribe action
- Lines 212-213 preserve the subtle difference between current state and future state
Also applies to: 212-214, 218-218
108-108: LGTM! Content preference labels are consistent across files.These translations match the corresponding entries in
ghost.json(lines 27 and 30), maintaining terminology consistency across the localization files.Also applies to: 116-116
✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.
| "{amount} off forever.": "永久减免{amount}", | ||
| "{discount}% discount": "{discount}% 折扣", | ||
| "{memberEmail} will no longer receive {newsletterName} newsletter.": "{memberEmail}将不会再收到{newsletterName}的新闻信。", | ||
| "{memberEmail} will no longer receive {newsletterName} newsletter.": "{memberEmail}将不会再收到新闻信。", |
There was a problem hiding this comment.
Missing {newsletterName} placeholder in translation.
The English source includes {newsletterName} to identify the specific newsletter, but the Chinese translation omits it:
- English:
"{memberEmail} will no longer receive {newsletterName} newsletter." - Chinese:
"{memberEmail}将不会再收到新闻信。"
This removes specific context for users about which newsletter they unsubscribed from. Consider:
- "{memberEmail} will no longer receive {newsletterName} newsletter.": "{memberEmail}将不会再收到新闻信。",
+ "{memberEmail} will no longer receive {newsletterName} newsletter.": "{memberEmail}将不会再收到{newsletterName}新闻信。",📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "{memberEmail} will no longer receive {newsletterName} newsletter.": "{memberEmail}将不会再收到新闻信。", | |
| "{memberEmail} will no longer receive {newsletterName} newsletter.": "{memberEmail}将不会再收到{newsletterName}新闻信。", |
🤖 Prompt for AI Agents
In `@ghost/i18n/locales/zh/portal.json` at line 9, The translation for the key
"{memberEmail} will no longer receive {newsletterName} newsletter." is missing
the {newsletterName} placeholder; update the Chinese value to include the
placeholder (e.g. "{memberEmail} 将不会再收到 {newsletterName} 新闻信。") so the rendered
message shows which newsletter was unsubscribed from and keep the placeholder
exactly as `{newsletterName}` and `{memberEmail}` to preserve interpolation.
1 participant
Benchmark PR from qodo-benchmark#222
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.