Testing makeover #99
Merged
Testing makeover #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
May 22, 2020 12:40
…icker into testing-makeover
…is NOT an ownProperty.
…d I'd just make the simple change here as a commit. I'm terrible at rebasing :/'
added 23 commits
June 28, 2020 11:08
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cypress to the rescue!
I added a tooon of tests using Cypress. Finally, this little library will have tests moving forward! There's still more tests to be written. For those, I added files declaring what tests should be added but I'll implement them in a follow up diff. Just wanna get this into master sooner than later.
Along the way, a few bugs were fixed and tweaks were made:
inlinePositionproperty.currentParen=>currentParenttypo.<span>inside each calendar day containing a number.e.whichande.keyCodesetDatenow correctly de-selects a date.