Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Keymap] Add pierrec83's Kyria keymap #9401

Merged
merged 1 commit into from
Jun 18, 2020
Merged

Conversation

pierrechevalier83
Copy link
Contributor

Upstream my daily driver keymap for the Kyria.

Description

Upstream my keymap for the kyria which uses 34 keys and uses a number of layers to provide most useful keys I use for programming and navigating my computer with minimal finger motion for optimal comfort.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark requested a review from a team June 14, 2020 17:21
keyboards/kyria/keymaps/pierrec83/encoders.c Outdated Show resolved Hide resolved
keyboards/kyria/keymaps/pierrec83/encoders.c Outdated Show resolved Hide resolved
keyboards/kyria/keymaps/pierrec83/readme.md Outdated Show resolved Hide resolved
@pierrechevalier83
Copy link
Contributor Author

Thanks for the review, @drashna. I have addressed your comments 😃

Copy link
Member

@noroadsleft noroadsleft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@noroadsleft noroadsleft requested a review from a team June 18, 2020 03:26
@drashna drashna merged commit 43b6f03 into qmk:master Jun 18, 2020
jakobaa pushed a commit to jakobaa/qmk_firmware that referenced this pull request Jul 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants