Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Process combos earlier & overlapping combos #8591

Merged
merged 20 commits into from
Aug 5, 2021
Merged

Commits on Mar 27, 2021

  1. Combo processing improvements.

    Now it is possible to use ModTap and LayerTap keys as part of combos.
    Overlapping combos also don't trigger all the combos, just exactly the
    one that you press.
    
    New settings:
    - COMBO_MUST_HOLD_MODS
    - COMBO_MOD_TERM
    - COMBO_TERM_PER_COMBO
    - COMBO_MUST_HOLD_PER_COMBO
    - COMBO_STRICT_TIMER
    - COMBO_NO_TIMER
    sevanteri committed Mar 27, 2021
    Configuration menu
    Copy the full SHA
    319d7e8 View commit details
    Browse the repository at this point in the history
  2. Remove the size flags from combo_t struct boolean members.

    This in the end actually saves space as the members are accessed so many
    times. The amount of operations needed to access the bits uses more
    memory than setting the size saves.
    sevanteri committed Mar 27, 2021
    Configuration menu
    Copy the full SHA
    f784bb3 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    86d235b View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    3d75ece View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    a165063 View commit details
    Browse the repository at this point in the history
  6. Update docs/feature_combo.md

    Co-authored-by: precondition <57645186+precondition@users.noreply.github.com>
    sevanteri and precondition committed Mar 27, 2021
    Configuration menu
    Copy the full SHA
    faffb46 View commit details
    Browse the repository at this point in the history
  7. Update quantum/process_keycode/process_combo.c

    Co-authored-by: precondition <57645186+precondition@users.noreply.github.com>
    sevanteri and precondition committed Mar 27, 2021
    Configuration menu
    Copy the full SHA
    443a35f View commit details
    Browse the repository at this point in the history
  8. Add EXTRA_SHORT_COMBOS option.

    Stuff combo's `disabled` and `active` flags into `state`. Possibly can
    save some space.
    sevanteri committed Mar 27, 2021
    Configuration menu
    Copy the full SHA
    f7d198d View commit details
    Browse the repository at this point in the history

Commits on Mar 28, 2021

  1. Add more examples and clarify things with dict management system.

    - Simple examples now has a combo that has modifiers included.
    - The slightly more advanced examples now are actually more advanced
      instead of just `tap_code16(<modded-keycode>)`.
    - Added a note that `COMBO_ACTION`s are not needed anymore as you can
      just use custom keycodes.
    - Added a note that the `g/keymap_combo.h` macros use the
      `process_combo_event` function and that it is not usable in one's
      keymap afterwards.
    sevanteri committed Mar 28, 2021
    Configuration menu
    Copy the full SHA
    322ec38 View commit details
    Browse the repository at this point in the history

Commits on Mar 29, 2021

  1. Update docs/feature_combo.md

    Co-authored-by: precondition <57645186+precondition@users.noreply.github.com>
    sevanteri and precondition authored Mar 29, 2021
    Configuration menu
    Copy the full SHA
    fd1b138 View commit details
    Browse the repository at this point in the history
  2. Update docs/feature_combo.md

    Co-authored-by: precondition <57645186+precondition@users.noreply.github.com>
    sevanteri and precondition authored Mar 29, 2021
    Configuration menu
    Copy the full SHA
    e6f6691 View commit details
    Browse the repository at this point in the history
  3. Update docs/feature_combo.md

    Co-authored-by: precondition <57645186+precondition@users.noreply.github.com>
    sevanteri and precondition authored Mar 29, 2021
    Configuration menu
    Copy the full SHA
    98a9228 View commit details
    Browse the repository at this point in the history
  4. Update docs/feature_combo.md

    Co-authored-by: precondition <57645186+precondition@users.noreply.github.com>
    sevanteri and precondition authored Mar 29, 2021
    Configuration menu
    Copy the full SHA
    8dded27 View commit details
    Browse the repository at this point in the history
  5. Update docs/feature_combo.md

    Co-authored-by: precondition <57645186+precondition@users.noreply.github.com>
    sevanteri and precondition authored Mar 29, 2021
    Configuration menu
    Copy the full SHA
    910179d View commit details
    Browse the repository at this point in the history

Commits on Mar 30, 2021

  1. Configuration menu
    Copy the full SHA
    af46b9f View commit details
    Browse the repository at this point in the history
  2. Update docs/feature_combo.md

    Co-authored-by: precondition <57645186+precondition@users.noreply.github.com>
    sevanteri and precondition authored Mar 30, 2021
    Configuration menu
    Copy the full SHA
    3c69a5e View commit details
    Browse the repository at this point in the history

Commits on Apr 2, 2021

  1. Fix sneaky infinite loop with combo_disable()

    No need to call `dump_key_buffer` when disabling combos because the
    buffer is either being dumped if a combo-key was pressed, or the buffer is empty
    if a non-combo-key is pressed.
    sevanteri committed Apr 2, 2021
    Configuration menu
    Copy the full SHA
    36f6f4a View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2021

  1. Update docs/feature_combo.md

    Co-authored-by: precondition <57645186+precondition@users.noreply.github.com>
    sevanteri and precondition authored Jul 25, 2021
    Configuration menu
    Copy the full SHA
    4c8d80b View commit details
    Browse the repository at this point in the history
  2. Update docs/feature_combo.md

    Co-authored-by: precondition <57645186+precondition@users.noreply.github.com>
    sevanteri and precondition authored Jul 25, 2021
    Configuration menu
    Copy the full SHA
    863fc28 View commit details
    Browse the repository at this point in the history

Commits on Aug 5, 2021

  1. Configuration menu
    Copy the full SHA
    29ccd15 View commit details
    Browse the repository at this point in the history