Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VIA Support: Tada68 #8289

Merged
merged 2 commits into from
Mar 4, 2020
Merged

VIA Support: Tada68 #8289

merged 2 commits into from
Mar 4, 2020

Conversation

mechmerlin
Copy link
Contributor

@mechmerlin mechmerlin commented Mar 1, 2020

Description

Add VIA support for Tada68. I think this is one of the boards that could use VIA as flashing it is so prone to error.

I left the VID as 0xFEED as I couldn't find reliable info as to who or what org actually created the Tada.

Tested by SaltedPork =)

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr zvecr requested a review from a team March 2, 2020 06:21
@wilba
Copy link
Contributor

wilba commented Mar 2, 2020

@mechmerlin I'd prefer not to start a precedent letting 0xFEED into the VIA definitions... if the source of a PCB is unknown, then perhaps just use the PCB name, set VID to "TA" and PID to 0x0001 ?

@mechmerlin
Copy link
Contributor Author

@mechmerlin I'd prefer not to start a precedent letting 0xFEED into the VIA definitions... if the source of a PCB is unknown, then perhaps just use the PCB name, set VID to "TA" and PID to 0x0001 ?

Sounds good, I will not feed those values into VIA =P

@drashna drashna merged commit 31662af into qmk:master Mar 4, 2020
HokieGeek pushed a commit to HokieGeek/qmk_firmware that referenced this pull request Mar 5, 2020
* tada68 via files

* change vid and pid based on wilba's recommendaton
nesth pushed a commit to nesth/qmk_firmware that referenced this pull request Mar 5, 2020
* upstream/master: (37 commits)
  Add RGB lighting through one of the free pins (qmk#8294)
  [Keymap] Adding the 4sStylZ xd75 (qmk#8285)
  YD60MQ refactor and Configurator layout support (qmk#8313)
  [Keyboard] Forget to ifdef Super16 led config (qmk#8314)
  [Keyboard] Switch to RGB Matrix for Super16 (qmk#8305)
  [Keymap] Keymap Update (qmk#8309)
  New Keyboard: SiddersKB Majbritt (Pronounced My Brit) (qmk#8260)
  [Keyboard] VIA Support: Tada68 (qmk#8289)
  [Keyboard] LFK78 refactor (qmk#7835)
  [Keymap] new userspace for ibnuda (qmk#8221)
  [Keymap] Add crd's equinox keymap (qmk#8251)
  [Keymap] Feature/alfrdmalr/keymap update (qmk#8174)
  Fix bootloader definition for namecard2x4 (qmk#8301)
  Update Hungarian keymap and add sendstring LUT (qmk#8220)
  Remove "ugly hack in usb_main.c" comments (qmk#8296)
  Update encoder functions for Iris VIA keymap (qmk#8295)
  Reduce PROGMEM usage for sendstring LUT (qmk#8109)
  [Docs] Update ISP Flashing guide (qmk#8149)
  Rewrite the Bathroom Epiphanies Frosty Flake matrix and LED handling (qmk#8243)
  Add onekey keymap for testing reset to bootloader. (qmk#8288)
  ...
c0psrul3 pushed a commit to c0psrul3/qmk_firmware that referenced this pull request Mar 23, 2020
* tada68 via files

* change vid and pid based on wilba's recommendaton
sowbug pushed a commit to sowbug/qmk_firmware that referenced this pull request Apr 2, 2020
* tada68 via files

* change vid and pid based on wilba's recommendaton
@mechmerlin mechmerlin deleted the feature/tada_via branch April 18, 2020 03:16
kylekuj pushed a commit to kylekuj/qmk_firmware that referenced this pull request Apr 21, 2020
* tada68 via files

* change vid and pid based on wilba's recommendaton
jakeisnt pushed a commit to jakeisnt/qmk_firmware that referenced this pull request Aug 20, 2020
* tada68 via files

* change vid and pid based on wilba's recommendaton
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants